fix(cli): clarify version-triggered daemon restart - #1525
Conversation
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Validation note: the patch-specific checks pass locally (focused regression suite, rustfmt, binary-target Clippy, and full repository Dylint), and the PR’s formatting/docs/policy/platform/build-facade gates pass. The remaining CI failures are confirmed baseline infrastructure failures also addressed by #1523: the Dylint workflow invokes missing |
Summary
Validation
soldr cargo test -p fbuild-cli --bin fbuild daemon_client::restart_diag::tests::post_respawn_warningsoldr rustfmt --check crates/fbuild-cli/src/daemon_client/restart_diag.rssoldr cargo clippy -p fbuild-cli --bin fbuild -- -D warningsuv run --no-project -m ci.run_dylint --package fbuild-cliRepository-wide all-target clippy currently reports pre-existing
option_env_unwrapfindings in integration tests onmain; the affected binary target passes cleanly.Closes #1521