Skip to content

fix(cli): clarify version-triggered daemon restart - #1525

Merged
zackees merged 1 commit into
mainfrom
fix/1521-version-restart-diagnostic
Sep 27, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/1521-version-restart-diagnostic

Conversation

@zackees

@zackees zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member

Summary

  • distinguish CLI/daemon version mismatch from same-version binary replacement
  • avoid falsely claiming the executable changed when only versions differ
  • add focused regression coverage while preserving existing mtime and foreign-image cases

Validation

  • soldr cargo test -p fbuild-cli --bin fbuild daemon_client::restart_diag::tests::post_respawn_warning
  • soldr rustfmt --check crates/fbuild-cli/src/daemon_client/restart_diag.rs
  • soldr cargo clippy -p fbuild-cli --bin fbuild -- -D warnings
  • uv run --no-project -m ci.run_dylint --package fbuild-cli
  • pre-push review: clean

Repository-wide all-target clippy currently reports pre-existing option_env_unwrap findings in integration tests on main; the affected binary target passes cleanly.

Closes #1521

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6baeb82b-8c1b-4970-ab59-b0c2713940ec

📥 Commits

Reviewing files that changed from the base of the PR and between cf1724e and daa6459.

📒 Files selected for processing (1)
  • crates/fbuild-cli/src/daemon_client/restart_diag.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees

zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

Validation note: the patch-specific checks pass locally (focused regression suite, rustfmt, binary-target Clippy, and full repository Dylint), and the PR’s formatting/docs/policy/platform/build-facade gates pass. The remaining CI failures are confirmed baseline infrastructure failures also addressed by #1523: the Dylint workflow invokes missing rg on all runners, while all-target Clippy fails in pre-existing fbuild-daemon/tests/port_recovery.rs on option_env_unwrap. Neither failure reaches or references this PR’s changed file.

@zackees
zackees merged commit aee2825 into main Sep 27, 2026
16 of 22 checks passed
@zackees
zackees deleted the fix/1521-version-restart-diagnostic branch September 27, 2026 20:15
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

follow-up: distinguish version-triggered post-respawn warnings from #1481

1 participant