Skip to content

Fix Dylint test path checks and preserve dependency cache - #1522

Merged
zackees merged 1 commit into
mainfrom
fix/dylint-cargo-bin-env
Sep 27, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/dylint-cargo-bin-env

Conversation

@zackees

@zackees zackees commented Sep 27, 2026

Copy link
Copy Markdown
Member

The nightly Dylint workspace check exposed Cargo test-binary paths missing during cargo check. Use option_env so tests still require the paths when executed, while cargo check can compile them. Refresh workspace source mtimes for platform observations instead of changing RUSTFLAGS on every run and invalidating all dependencies. Verified targeted fbuild-daemon integration test cargo check in local Docker, Rust formatting, and workflow tests.

@zackees
zackees merged commit 2297cd4 into main Sep 27, 2026
14 of 19 checks passed
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bb05ddec-721d-4c77-a5a5-c502911f9bc1

📥 Commits

Reviewing files that changed from the base of the PR and between b910aa2 and 72e3d0a.

📒 Files selected for processing (8)
  • .github/workflows/dylint.yml
  • crates/fbuild-cli/tests/ci_command.rs
  • crates/fbuild-cli/tests/daemon_crash_recovery.rs
  • crates/fbuild-cli/tests/lib_select.rs
  • crates/fbuild-cli/tests/test_emu_exit_code.rs
  • crates/fbuild-daemon/tests/legacy_daemon_transition.rs
  • crates/fbuild-daemon/tests/port_recovery.rs
  • crates/fbuild-daemon/tests/process_containment.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant