fix(build): fail oversize images, compile only reached lib/ libraries, warn on ignored version pins

[zackees]

Fixes #1407, fixes #1409, fixes #1410.

#1409 — oversize firmware exited 0

• Linker::link_all calls enforce_size_limits after sizing, on both the fresh-link and the skip-relink path. Flash over the board maximum fails the build with PlatformIO's checkprogsize wording.
• RAM over the maximum is fatal on AVR (AvrLinker::ram_overflow_is_fatal), where data + bss is exactly the single SRAM, matching arduino-cli. Elsewhere it is a Warning! line in the size report, as in PlatformIO, because data + bss over-counts on multi-region MCUs (Teensy 4 DMAMEM/EXTMEM).
• bloat_analysis builds (--noinhibit-exec) still accept oversize images, since that mode exists to analyze them.
• ESP32 checks against the app partition from the resolved partitions CSV (factory, else ota_0), the way PlatformIO's espressif32 builder does. Most ESP32 board JSONs carry the chip flash size, and a few carry odd values (for example weactstudio_esp32c3coreboard: 393216). max_flash still drives esptool --flash-size, so this uses a separate with_app_size_limit.

#1410 — every lib/ library was compiled

• New framework_libs::select_local_libraries runs the LDF walk from project translation units over lib/*, following library-to-library edges. lib_deps names force selection (new fbuild_library_select::resolve_declared).
• The walk is textual (every #if arm is scanned). The active scan treats compiler builtins (__XTENSA__, __AVR__) as defined nowhere and could drop a library the compiler includes. The textual walk can only over-select, and over-selecting is what the old behavior did for every library.
• The generic pipeline and the ESP32 pipeline both compile only the selection. Framework-library seeding also uses only the selected local libraries, so "what compiles is what seeds" still holds. When there is no src/, the sketch-root walk no longer seeds from lib/.

#1407 — version pins were ignored silently

• fbuild_config::ignored_version_pins flags platform = name@version and bare platform_packages = name@version entries. BuildContext writes them to the build output. The existing ESP32 warning only reached the daemon log via tracing. Each warning names the URL form that is honored.

Validation

• Unit tests: SizeInfo::{flash,ram}_overflow, enforce_size_limits, partition CSV parsing, ignored_version_pins, and six local-lib selection cases (the report's layout, a transitive local lib, a builtin-macro guard, lib_deps, a sketch at the project root, and an unselected lib not seeding framework selection). bash test passes and clippy -D warnings is clean.
• End-to-end with the built CLI (FBUILD_DEV_MODE=1):
  • build succeeded for firmware at 135% of flash / 2059% of RAM on an Uno #1409 repro (14×3000 B arrays, Uno) now fails with The program size (43662 bytes) is greater than maximum allowed (32256 bytes); The data size (42184 bytes) ..., exit 1. The second run, which skips the relink, also fails. A RAM-only overflow (6184/2048) fails too.
  • Local lib/ libraries are compiled regardless of the sketch's include graph #1410 repro (lib/FastLED + a SAMD-only lib that includes <malloc.h>, Uno): fbuild 2.5.22 fails with the exact malloc.h error from the report. This branch builds (4.6 KB flash). On ESP32 only lib/FastLED is compiled.
  • A pinned platform version is silently ignored — in platform and in platform_packages #1407: platform = espressif32@6.5.0 plus platform_packages = platform-espressif32@6.5.0 prints both warnings in the build output. ESP32 flash now reports against 1.25 MB (default.csv) or 3.00 MB (huge_app.csv).

[coderabbitai]

Warning

Review limit reached

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: ccd84fe3-690f-4257-bb53-d61dbdacaf48

📥 Commits

Reviewing files that changed from the base of the PR and between 1c0ebfa and 82171de.

📒 Files selected for processing (18)

• .github/workflows/check-ubuntu.yml
• crates/fbuild-build-engine/src/build_output.rs
• crates/fbuild-build-engine/src/framework_libs.rs
• crates/fbuild-build-engine/src/framework_libs_local_tests.rs
• crates/fbuild-build-engine/src/linker.rs
• crates/fbuild-build-engine/src/pipeline/compile.rs
• crates/fbuild-build-engine/src/pipeline/context.rs
• crates/fbuild-build-engine/src/pipeline/sequential.rs
• crates/fbuild-build-esp/src/esp32/esp32_linker.rs
• crates/fbuild-build-esp/src/esp32/orchestrator/boot_artifacts.rs
• crates/fbuild-build-esp/src/esp32/orchestrator/build.rs
• crates/fbuild-build-esp/src/esp32/orchestrator/local_libs.rs
• crates/fbuild-build-mcu/src/avr/avr_linker.rs
• crates/fbuild-config/src/lib.rs
• crates/fbuild-config/src/platform_packages.rs
• crates/fbuild-core/src/lib.rs
• crates/fbuild-library-select/src/lib.rs
• docs/architecture/library-selection.md

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}