Repository navigation
Expect runtime activity for the rooted-constant rule test on every Julia version - #3732
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## vc/enzyme-jll-0.0.300 #3732 +/- ##
=========================================================
+ Coverage 80.05% 80.10% +0.04%
=========================================================
Files 71 71
Lines 24172 24172
=========================================================
+ Hits 19351 19363 +12
+ Misses 4821 4809 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
The delta there is quite big,. You should update to 1.13.1 |
…lia version The test's 1.13-only branch encoded that attribute inference proved the data half of the split convention readnone from the body of test_trace!, so the call worked without runtime activity there. test_trace! has a custom rule, which may read the whole argument, and since EnzymeAD/Enzyme#3352 the body of such a function no longer yields that inference on any version, so 1.13 now throws EnzymeRuntimeActivityError like the others. This is the expectation #3610 states as well. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G84mmXoaait2MBqCH5BKNb
vchuravy
force-pushed
the
wm/rooted-const-test
branch
from
October 1, 2026 10:33
54e3921 to
c15d1c9
Compare
vchuravy
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Julia 1.13 job of Enzyme's "Julia Enzyme CI" after EnzymeAD/Enzyme#3352 (e.g. https://github.com/EnzymeAD/Enzyme/actions/runs/36807106156/job/110193998438), which fails in
test/rules/rules.jl"Rooted constant with active non-rooted arg".The test's 1.13-only branch encoded that attribute inference on LLVM 20 proved the data half of the split convention
readnonefrom the body oftest_trace!, so the call worked without runtime activity there.test_trace!has a custom rule, which may read the whole argument, and since #3352 the body of such a function no longer yields that inference on any version, so 1.13 now throwsEnzymeRuntimeActivityErrorlike every other version. The test expects that everywhere; it is the same expectation #3610 states (its hunk for this file), extracted so it can land on its own.Verified on Julia 1.13.0-rc1 with Enzyme main (including #3352) built locally:
rules/rulesfails before (28 pass, 1 error) and passes after (30 of 30).🤖 Generated with Claude Code
https://claude.ai/code/session_01G84mmXoaait2MBqCH5BKNb