Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3736 +/- ##
===========================================
+ Coverage 49.08% 79.90% +30.82%
===========================================
Files 58 71 +13
Lines 23379 24820 +1441
===========================================
+ Hits 11476 19833 +8357
+ Misses 11903 4987 -6916 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
An error occurred while trying to automatically change base from
wm/rooted-const-test
to
vc/enzyme-jll-0.0.300
October 1, 2026 13:22
An error occurred while trying to automatically change base from
wm/rooted-const-test
to
vc/enzyme-jll-0.0.300
October 1, 2026 13:23
vchuravy
force-pushed
the
vc/custom-rule-regression-tests
branch
from
October 1, 2026 13:23
ccfe25a to
5923d10
Compare
vchuravy
added this pull request to stack #3737
October 1, 2026 21:39
vchuravy
force-pushed
the
vc/custom-rule-regression-tests
branch
from
October 3, 2026 01:56
5923d10 to
84190e7
Compare
vchuravy
removed this pull request from stack #3737
October 3, 2026 01:56
vchuravy
added this pull request to stack #3739
October 3, 2026 01:57
Both failed with Enzyme_jll 0.0.299 (a segfault for #3570, a dropped store for the aggregate with inline roots) and pass with 0.0.300, which includes EnzymeAD/Enzyme#3352. Taken from #3610. Assisted-by: Claude Code (Opus 5.5)
vchuravy
force-pushed
the
vc/custom-rule-regression-tests
branch
from
October 7, 2026 13:32
84190e7 to
c25c0b6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3732, which is stacked on #3734 (Enzyme_jll 0.0.300).
A custom rule may read an argument that the body of its function never reads. Attribute inference on the primal body used to mark such an argument
readnone, which broke the rule in two ways. Since EnzymeAD/Enzyme#3352 and #3353, which are in Enzyme_jll 0.0.300, nothing infersreadnoneorwriteonlyon the parameters of a function with a custom rule. This PR adds the regression tests from #3610, without its code changes:test/rules/unread_const_arg.jl(Custom forward rule argument becomesjl_nothingacross a@noinlinehelper (SIGSEGV) #3570): aConstargument read only by the rule, behind a@noinlinefunction. Covers forward, combined reverse and split reverse mode, and a constant callee that calls a function with a rule.test/rules/custom_rule_inline_roots.jl: an aggregate with inline roots whose data half is read only by the rule. TheDSEPassofmiddle_optimize!used to delete the caller's store into it.Run locally with Enzyme.jl
main(no #3610 code changes):unread_const_arg.jlcustom_rule_inline_roots.jlNot run locally on 1.10 or 1.11.
Fixes #3570.
🤖 Generated with Claude Code