Update the icepack submodule to v1.5.3 by eclare108213 · Pull Request #8054 · E3SM-Project/E3SM

eclare108213 · 2026-02-10T20:34:25Z

Replaces the Icepack submodule in E3SM with Icepack version 1.5.3 and updates MPAS-seaice to accommodate the new code.

This PR is climate-changing due to changes in the Icepack column physics modules to fix bugs in the meltpond tracer specification and pond water density, and to remove residual ice. A number of other bug fixes and enhancements are also included, which do not affect E3SM at this time. In particular, this PR adds a new sea-level meltpond parameterization, currently turned off. Icepack support for wave-ice coupling in E3SM is also included in this PR, to be fully implemented in a separate PR.

Fixes #7991

[NML]
[CC]

eclare108213 · 2026-02-10T20:37:12Z

The code changes are more fully described in https://e3sm.atlassian.net/wiki/spaces/pd/pages/5813108745/Overview+of+Icepack+synchronization+February+2026.

The icepack submodule should be pointing to commit cf1d460fbb6a13d28988f798b33734f46d70a9dc

github-actions · 2026-02-10T20:37:50Z

PR Preview Action v1.8.1
🚀 View preview at https://E3SM-Project.github.io/E3SM/pr-preview/pr-8054/
Built to branch `gh-pages` at 2026-04-14 15:34 UTC. Preview will be ready when the GitHub Pages deployment is complete.

jonbob · 2026-02-12T18:04:28Z

@eclare108213 -- I ran some tests of this PR, and it does pass the ERS, PEM and PET ice_developer tests (except of course for changes to the namelists and results). I also ran the scripts that semi-automate making bld files consistent with Registry and it came up with some differences in namelist_definition_mpassi.xml. Most of them look like ordering of configs and their definitions, and maybe one small difference in this definition:

<entry id="config_dynamics_mass_minimum" type="real"
        category="velocity_solver" group="velocity_solver">
-Minimum seaice and snow mass for dynamics calculation.
+Minimum sea ice mass for dynamics calculation.

jonbob · 2026-02-12T22:13:23Z

Sorry @eclare108213 -- I should have said that I'm happy to push the changes the scripts come up with to your branch. I mostly wanted to give you a heads-up

eclare108213 · 2026-02-12T22:23:36Z

Sorry @eclare108213 -- I should have said that I'm happy to push the changes the scripts come up with to your branch. I mostly wanted to give you a heads-up

No worries, this was super easy, and I improved the English grammar too...

darincomeau · 2026-02-17T15:46:42Z

I'm currently running B-case comparison tests on Chrysalis, will post results when available.

darincomeau · 2026-03-18T21:01:13Z

Results from 30 year B-case comparison, run in LR piControl (ne30pg2_r05_IcoswISC30E3r5.WCYCL1850): https://e3sm.atlassian.net/wiki/spaces/pd/pages/5960761345/Icepack+v1.5.3

Results here use existing default level ice melt pond scheme.

Baseline (current Icepack v1.5.0): MPAS-Analysis years 21-29
Icepack v1.5.3 update: MPAS-Analysis years 21 - 29

The baseline run crashed at the end of year 30 in a snow grain radius calculation, a known bug fixed in Icepack v1.5.3.

Some comparison plots:
NH winter sea ice concentration
Icepack v1.5.3

Baseline

NH winter sea ice thickness
Icepack v1.5.3

Baseline

SH winter sea ice concentration
Icepack v1.5.3

Baseline

SH winter sea ice thickness
Icepack v1.5.3

Baseline

darincomeau

Approved based on above B-case testing

darincomeau · 2026-03-24T14:48:30Z

@eclare108213 I think this is ready to move out of 'Draft' mode.

EDIT: We should also add "Fixes #7991" in the PR description so it will close that issue. I can do that @eclare108213 (don't want to edit that without giving heads up).

proteanplanet

Approved based on extensive testing.

erinethomas

Approved - based on extensive testing in fully coupled wave configurations.

njeffery

Approved based on provided analysis.

proteanplanet · 2026-03-24T15:47:31Z

@jonbob We are ready to add this to master to help finalize v3.2 (a few more changes coming to the final configuration)

jonbob · 2026-03-24T16:16:33Z

@proteanplanet -- I assume this should have the post3.1 tag?

darincomeau · 2026-03-25T19:05:52Z

This has also passed the e3sm_cryo_developer test suite and

SMS.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel
ERS.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel
PEM.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel
PET.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel

darincomeau · 2026-04-08T20:22:09Z

This needs to be rebased following the merge of #7958 and the above conflict resolved. @erinethomas has a patch commit that's needed here given the changes to wave sea ice coupling that I've tested (but we should re-run basic smoke testing here).

darincomeau · 2026-04-09T04:06:16Z

Rebased on current master, added erinethomas@7659888 to reconcile changes with #7958, and force-pushed updated.

Passes e3sm_cryo_developer test suite and
SMS_P640.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_intel

Update the icepack submodule to v1.5.3 Replaces the Icepack submodule in E3SM with Icepack version 1.5.3 and updates MPAS-seaice to accommodate the new code. This PR is climate-changing due to changes in the Icepack column physics modules to fix bugs in the meltpond tracer specification and pond water density, and to remove residual ice. A number of other bug fixes and enhancements are also included, which do not affect E3SM at this time. In particular, this PR adds a new sea-level meltpond parameterization, currently turned off. Icepack support for wave-ice coupling in E3SM is also included in this PR, to be fully implemented in a separate PR. Fixes #7991 [NML] [CC]

jonbob · 2026-04-14T20:20:06Z

Passes (with expected baseline and NML DIFFs):

SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_intel.allactive-wcprod
SMS_Ln9.ne4pg2_oQU480.F2010.pm-cpu_intel.eam-outfrq9s
SMS_P12x2.ne4pg2_oQU480.WCYCL1850NS.pm-cpu_gnu.allactive-mach_mods
e3sm_ice_developer on pm-cpu with intel

Merged to next

jonbob · 2026-04-15T18:40:55Z

merged to master and expected baseline and NML DIFFs are set to be blessed after pm-cpu returns from maintenance. But there may be more due to ekat build fails on some tests

eclare108213 requested review from darincomeau, erinethomas, njeffery and proteanplanet February 10, 2026 20:34

eclare108213 assigned jonbob Feb 10, 2026

eclare108213 added MPAS-seaice Concerning the MPAS-seaice model CC PR is climate changing labels Feb 10, 2026

This was referenced Mar 16, 2026

Wave-Sea Ice Coupling #7958

Merged

Snow grain radius out of bounds #7991

Closed

darincomeau approved these changes Mar 24, 2026

View reviewed changes

proteanplanet approved these changes Mar 24, 2026

View reviewed changes

erinethomas approved these changes Mar 24, 2026

View reviewed changes

njeffery approved these changes Mar 24, 2026

View reviewed changes

eclare108213 marked this pull request as ready for review March 24, 2026 15:46

rljacob added the 3.2beta Needed for the 3.2 tag. label Mar 24, 2026

eclare108213 added 3 commits April 8, 2026 20:31

remove zsalinity comments (complete deprecation)

5ec28d3

move minimum area and mass parameters to namelist

30cfe96

link itd minima to dyn values and add sea-level pond scheme

9e56274

eclare108213 and others added 9 commits April 8, 2026 20:33

make sea-level ponds the default

d9dafcb

turn off level-ice ponds as the default

e6432b8

update documentation

cf30fa0

modify 3 pond parameters to allow different values for each pond scheme

24dec0e

update submodule to icepack v1.5.3

e55e7d0

reset default melt pond scheme to level-ice ponds

22cd1fb

fix linter link complaints

7422c51

make namelist descriptions consistent

9c8d8fa

rebase WaveCoupling for icepackV1_5_3 update

2ce7a3a

darincomeau force-pushed the eclare/seaice/icepack_1-5-3 branch from adbf71a to 2ce7a3a Compare April 9, 2026 04:04

Make bld file consistent with Registry

e459138

jonbob added the NML label Apr 14, 2026

jonbob merged commit b6feb85 into master Apr 15, 2026
2 checks passed

jonbob deleted the eclare/seaice/icepack_1-5-3 branch April 15, 2026 17:29

darincomeau mentioned this pull request Apr 15, 2026

Change default sea ice melt pond scheme to sea level melt ponds #8286

Merged

Copilot AI mentioned this pull request Apr 16, 2026

Remove unused snicar input file reads #8289

Draft

Uh oh!

Conversation

eclare108213 commented Feb 10, 2026 • edited by jonbob Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eclare108213 commented Feb 10, 2026

Uh oh!

github-actions Bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-04-14 15:34 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

jonbob commented Feb 12, 2026

Uh oh!

jonbob commented Feb 12, 2026

Uh oh!

eclare108213 commented Feb 12, 2026

Uh oh!

darincomeau commented Feb 17, 2026

Uh oh!

darincomeau commented Mar 18, 2026

Uh oh!

darincomeau left a comment

Choose a reason for hiding this comment

Uh oh!

darincomeau commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

proteanplanet left a comment

Choose a reason for hiding this comment

Uh oh!

erinethomas left a comment

Choose a reason for hiding this comment

Uh oh!

njeffery left a comment

Choose a reason for hiding this comment

Uh oh!

proteanplanet commented Mar 24, 2026

Uh oh!

jonbob commented Mar 24, 2026

Uh oh!

darincomeau commented Mar 25, 2026

Uh oh!

darincomeau commented Apr 8, 2026

Uh oh!

darincomeau commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonbob commented Apr 14, 2026

Uh oh!

Uh oh!

jonbob commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

eclare108213 commented Feb 10, 2026 •

edited by jonbob

Loading

github-actions Bot commented Feb 10, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-04-14 15:34 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

darincomeau commented Mar 24, 2026 •

edited

Loading

darincomeau commented Apr 9, 2026 •

edited

Loading