Adds Envirosuits and Co. to The Loadout#1072
Conversation
Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
Renamed some of the cultural items to make them easier to identify/search for according to how they show in game Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
They'll be back later Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
beeperoil
requested review from
00-Steven,
carda-sometimesknownas-paxilmaniac and
desertmote
as code owners
|
i know i'ma have to change my PR to match #1068 's later on 👍 |
carda-sometimesknownas-paxilmaniac
left a comment
carda-sometimesknownas-paxilmaniac
left a comment
There was a problem hiding this comment.
Envirohelmets and envirosuits will need to be in their own subcategory, not just with "helmets" and "suits"
can do |
kannthus
left a comment
kannthus
left a comment
There was a problem hiding this comment.
Looks good to me personally, I agree the grouping looks much neater.
Good job Kiri ❤️
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| /datum/loadout_item/gloves/envirogloves | ||
| group = "Envirogloves" | ||
| abstract_type = /datum/loadout_item/gloves/envirogloves | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/black | ||
| name = "Black Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/black | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/white | ||
| name = "White Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/white | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/nitrile | ||
| name = "Nitrile Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/plasmanitrile | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/red | ||
| name = "Red Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/robot | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/orange | ||
| name = "Orange Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/engineer | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/blue | ||
| name = "Blue Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/atmos | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/tan | ||
| name = "Tan Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/cargo | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/explorer | ||
| name = "Explorer Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/explorer | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/purple | ||
| name = "Purple Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/janny | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/teal | ||
| name = "Teal Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/centcom_official | ||
|
|
||
| /datum/loadout_item/gloves/envirogloves/green | ||
| name = "Green Envirogloves" | ||
| item_path = /obj/item/clothing/gloves/color/plasmaman/centcom_commander |
There was a problem hiding this comment.
consider changing to Phorid Envirogloves (Colour) parallel to the other options
There was a problem hiding this comment.
would it be out of scope to subtype them? otherwise they'll be named centcom official/centcom commander envirogloves by default ingame
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
00-Steven
left a comment
00-Steven
left a comment
There was a problem hiding this comment.
to refresh as a new review, given it's been a while
dawson makes a very good point that a lot of the gloves aren't just colour subtypes, but named subtypes with (supposedly) specific icon states
DopplerShift/code/modules/clothing/gloves/plasmaman.dm
Lines 106 to 119 in bd62e48
so I would request these be their own item types/subtypes
5 participants
About The Pull Request
Why It's Good For The Game
It allows for more customization, especially for a species (Phorids) that has little drip to work with in the first place.
Testing Evidence
Changelog
🆑
add: Added items to the head, hands, and undersuit categories in the loadout for Phorids.
/:cl: