Skip to content

feat: Add playback rate settings with persistence options - #1073

Closed
vicente-higino wants to merge 2 commits into
DonutWare:developfrom
vicente-higino:feat-persistent-playback-rate
Closed

feat: Add playback rate settings with persistence options#1073
vicente-higino wants to merge 2 commits into
DonutWare:developfrom
vicente-higino:feat-persistent-playback-rate

Conversation

@vicente-higino

Copy link
Copy Markdown

Pull Request Description

Summary

This PR adds configurable playback rate preferences, allowing users to choose a default playback speed or automatically remember the last playback rate used.

Changes

  • Added a playbackRate field to PlayerSettings.
  • Added defaultPlaybackRate and rememberPlaybackRate to VideoPlayerSettingsModel.
  • Persist the last selected playback rate when Remember playback rate is enabled.
  • Added a Default playback rate setting for users who prefer a fixed playback speed.
  • Updated the player UI to support selecting, saving, and restoring playback rates.
  • Updated the ExoPlayer integration to apply the configured playback rate correctly.
  • Added tests covering playback rate settings, persistence, and restore behavior.

AI Disclosure

This implementation were developed with assistance from OpenAI Codex/ChatGPT. AI was used to help generate and refine portions of the implementation, while all generated code was reviewed, tested, and validated before inclusion.

Screenshots / Recordings

fladder_5gm1PervxO fladder_vwpBOpoj2s

Tested On

  • Android
  • Android TV
  • iOS
  • Linux
  • Windows
  • macOS
  • Web

- Introduced playbackRate field in PlayerSettings.
- Implemented rememberPlaybackRate and defaultPlaybackRate in VideoPlayerSettingsModel.
- Added functionality to persist last used playback rate.
- Updated UI components to allow users to set and remember playback rates.
- Enhanced ExoPlayer integration to apply playback rates.
- Added tests for playback rate settings and persistence behavior.
@vicente-higino
vicente-higino force-pushed the feat-persistent-playback-rate branch from e9371e8 to 29eefd6 Compare August 1, 2026 00:35
@vicente-higino
vicente-higino marked this pull request as ready for review August 1, 2026 01:21
@PartyDonut

Copy link
Copy Markdown
Collaborator

Thanks the contribution.

But this is not something I see a lot of use for.
Aside from the fact you have changed a lot of files that should not have been included in the PR.

@PartyDonut PartyDonut closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants