Drop the release build from CI - #5
Merged
Merged
Conversation
The ReleaseFast build dominated the CI run: check and test finish in a couple of minutes, then build spends far longer on Ghostty and the optimised compile. `native test` already compiles the app in Debug, so the marginal signal did not justify the wait on every pull request. Running `npm run build` is now a contributor responsibility, which CONTRIBUTING.md and the pull request template say explicitly rather than leaving people to assume CI covers it. Also skip the contributor check for bots. Dependabot's three pull requests were each labelled external-contributor and told they were not Docyrus members, which is noise on every dependency bump. The job keeps the name "build and test" so the required status check in the main ruleset keeps matching. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4JoCqrnJ47MqzHk9PsZ33
github-actions
Bot
added
the
external-contributor
|
Thanks for the pull request! Docyrus Open IDE is public to read and install, but while the project settles we See CONTRIBUTING.md for the current policy. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Buildstep from CI.checkandteststay.CONTRIBUTING.mdand the PR template to say CI no longer builds, so nobody assumes it does.Why
The ReleaseFast build dominated the run — on PR #1,
checkandtestfinished in a couple of minutes and the job was still onBuildwhen you merged.native testalready compiles the app in Debug, so the marginal signal did not justify that wait on every pull request.The bot fix is a defect in what I shipped: Dependabot's three PRs (#2, #3, #4) were each labelled
external-contributorand told they were not Docyrus members.github.event.pull_request.user.type != 'Bot'skips them.Trade-off you are accepting
Nothing verifies a ReleaseFast build on a pull request any more. A break that only appears under optimisation, or in the packaging path, now reaches
mainuncaught.npm run buildis a contributor responsibility, stated in both the contributing guide and the PR checklist.If that turns out to be too loose, the middle ground is a
Buildjob gated onpushtomainonly, or a nightly schedule — same coverage, none of the per-PR latency. Say the word and I will add it.Notes
build and testdeliberately: that string is the required status check in themainruleset, and the three open Dependabot PRs would be blocked forever if the context stopped matching. Renaming it totestmeans updating the ruleset in the same change, once those PRs are merged or closed — happy to do that as a follow-up.--yestoolchain fix from PR Prepare the repo for contributors, and land pending project and editor work #1 is confirmed working:CheckandTestboth passed on that run before you merged.How I verified it
npm run build— not run for this change; it touches only workflow YAML and Markdown🤖 Generated with Claude Code
https://claude.ai/code/session_01K4JoCqrnJ47MqzHk9PsZ33