Skip to content

Request @anilbeyazoglu on every pull request - #7

Merged
anilbeyazoglu merged 1 commit into
mainfrom
ci/review-routing
Sep 3, 2026
Merged

Request @anilbeyazoglu on every pull request#7
anilbeyazoglu merged 1 commit into
mainfrom
ci/review-routing

Conversation

@anilbeyazoglu

Copy link
Copy Markdown
Contributor

What changed

.github/CODEOWNERS now names @anilbeyazoglu as an owner on every path, alongside the existing teams. Every pull request will request his review automatically.

CONTRIBUTING.md says so, so contributors know who the review is waiting on.

What did not change, and why

The main ruleset is untouched: 1 approving review, code-owner review required.

GitHub cannot exempt a pull request's author from review requirements — bypass is actor-based, not author-based. I tested adding a named-user bypass actor to the ruleset and the API rejected it (HTTP 404 on actor_type: "User"); I confirmed afterwards that the ruleset was left intact.

You already have what you asked for through the OrganizationAdmin bypass that's been on the ruleset since it was created: your own PRs merge via the bypass confirmation rather than waiting for someone else's approval. That's how you merged #1 and #5.

Two consequences worth knowing:

  • The bypass is granted by org-admin role, so ardabeyazoglu has it too. There is no way to narrow it to one person short of changing his org role.
  • Your own PRs will still display "Review required" — the bypass shows up at the merge step, not in the status box.

Because you are now a code owner on every path, GitHub will not request a review on your own PRs (it never requests review from the author), so nothing new blocks you.

How I verified it

  • GET /codeowners/errors reports 0 errors on the current file; will re-check after merge, since that endpoint reads the default branch
  • Confirmed the ruleset is unchanged after the rejected bypass patch
  • Not applicable: no build, test, or app code touched

🤖 Generated with Claude Code

https://claude.ai/code/session_01K4JoCqrnJ47MqzHk9PsZ33

Team ownership alone let a review land with whichever team member the
round-robin picked. Name @anilbeyazoglu as an owner on every path so
every pull request requests his review, and say so in CONTRIBUTING.md.

The teams stay as co-owners, so their approval still satisfies the
requirement when he is unavailable.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K4JoCqrnJ47MqzHk9PsZ33
@anilbeyazoglu
anilbeyazoglu requested a review from a team as a code owner September 3, 2026 12:32
@github-actions github-actions Bot added the external-contributor PR opened by someone outside the Docyrus organization label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Thanks for the pull request!

Docyrus Open IDE is public to read and install, but while the project settles we
merge changes only from members of the Docyrus organization.
A maintainer will take a look and let you know whether we can accept this patch,
or suggest opening an issue to discuss it first.

See CONTRIBUTING.md for the current policy.

@anilbeyazoglu
anilbeyazoglu merged commit 7b0812d into main Sep 3, 2026
2 checks passed
@anilbeyazoglu
anilbeyazoglu deleted the ci/review-routing branch September 3, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor PR opened by someone outside the Docyrus organization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant