Repository navigation
Conversation
[Medium impact] The PR appears safe to merge based on the reviewed changes. SummaryAdds source-backed Real2Sim prototypes, bounded pose refinement, trajectory expansion, sequential execution, and synchronous recording with matching receipts.
|
Keep write progress with each retained episode, enforce external Pick lift targets and calibrated refinement frames, and reject oversized normalization outputs before allocation. Add focused regressions and correct CLI and legacy-surface CI expectations.
Check that shared-template capacity does not grow and retained native instance IDs remain unchanged. Exercise garbage collection around the reuse loop without treating unused-instance reclamation as a regression.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a source-backed Real2Sim path from annotated trajectory bundles through Atomic Skill assembly, bounded kinematic refinement, spatial/time expansion, sequential Task Program execution, and synchronous LeRobot recording. Pick, MoveHeldObject and Place retain their existing identities and complete-plan semantics.
Refs #709 and #708. Qualification is synthetic, B=1, same robot/assets, with a dynamic box, static support box and fixed ground. Real-data/hardware qualification, general joint-space collision optimization, continuous collision, RL, cross-robot transfer, parallel calls and B>1 host execution remain outside this slice.
Relationship to #799
This is an independent implementation against main and overlaps #799, including incompatible definitions of Real2SimTrajectory. The two PRs require an explicit integration or selection decision before both merge; this PR does not depend on #799.
Dependencies: existing SciPy, OSQP, Pinocchio/Coal and LeRobot dependencies; no package dependency changes.
Type of change
Validation
See
examples/expansion/trajectory/real2sim/REFINEMENT.mdfor the verification ladder and rerun commands,refinement_validation_report.jsonfor machine-readable results, andrefinement_comparison.pngfor the analytic comparison. The original nominal and repeated-program acceptance reports remain available separately.Greptile review follow-up
Validation of follow-up commit
de94d3f7a:Screenshots
Checklist