Repository navigation
fix: support OMP 18 host imports - #6
LaurensBosscher wants to merge 1 commit into
Conversation
Deep @oh-my-pi/* imports fail under OMP 18.2.5 extension loading because host onLoad only rewrites legacy scopes onto in-process shims. Switch to @earendil-works root imports (proven on this host) and register claude-opus-5 so existing modelRoles/fallbackChains keep resolving.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d727380e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { StringEnum, type AssistantMessage, type AssistantMessageEventStream, type Context, type Model, type SimpleStreamOptions, type Tool, type Usage } from "@earendil-works/pi-ai"; | ||
| import * as piAi from "@earendil-works/pi-ai"; | ||
| import { getModels } from "@earendil-works/pi-ai/compat"; | ||
| import { buildSessionContext, compact, keyHint, type CompactionEntry, type ExtensionAPI, type ExtensionUIContext } from "@earendil-works/pi-coding-agent"; |
There was a problem hiding this comment.
When this plugin is installed under OMP 16 or 17, these static imports are resolved before the extension can register, but those hosts provide the @oh-my-pi/* modules rather than the OMP 18-only @earendil-works/* host shims. The manifest still advertises @oh-my-pi/* >=16.3.6 peers and does not declare an OMP 18 minimum, so an installation that the package currently presents as compatible now fails at module load; either retain a compatibility path for the older host modules or explicitly require OMP 18 and stop advertising the older peers.
Useful? React with 👍 / 👎.
Changes
First of six ordered upstream PRs.
Verification
@earendil-works/*declarations.