Skip to content

feat: register Claude models from OMP catalog - #7

Open
LaurensBosscher wants to merge 2 commits into
DevVig:mainfrom
LaurensBosscher:upstream/02-model-catalog
Open

LaurensBosscher wants to merge 2 commits into
DevVig:mainfrom
LaurensBosscher:upstream/02-model-catalog

Conversation

@LaurensBosscher

Copy link
Copy Markdown

Changes

  • Register Claude models from the OMP catalog, including Opus and Sonnet 5.5, and map supported effort levels.
  • Document model and context-window behavior.

Stacked after #6: this branch includes its commit until #6 merges.

Verification

  • Catalog and effort unit tests passed in the local fork.
  • Real bridge requests were exercised for several registered models.

omp-install and others added 2 commits September 18, 2026 09:47
Deep @oh-my-pi/* imports fail under OMP 18.2.5 extension loading because
host onLoad only rewrites legacy scopes onto in-process shims. Switch to
@earendil-works root imports (proven on this host) and register
claude-opus-5 so existing modelRoles/fallbackChains keep resolving.
…, Fable 5.1, Mythos) + max effort

Derive the picker from the host's anthropic catalog instead of a hardcoded id
list, keeping the 1M/200K variant entries. Measured [1m] entitlements stay in
tables; unmeasured 1M-capable models default to 200K with a -1m alternate.
Map thinking levels onto each model's catalog effort ladder (adds max).
Fix unsuffixed entries throwing when their preferred window has no runtime.
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ae4fbf7-cb67-4b96-acdb-e0f0bc68d484
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T09:46:55.990679Z bdd567a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bdd567a2df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/models.ts
Comment on lines +89 to +90
for (let i = rank; i >= 0; i--) {
if (efforts.includes(CLAUDE_CODE_EFFORTS[i])) return CLAUDE_CODE_EFFORTS[i];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve direct max on max-backed Sonnet models

When AskClaude uses the newly allowed thinking: "max" with claude-sonnet-4-6, the injected map only contains xhigh: "max", so a direct max request falls through to this ladder scan. With the Sonnet 4.6 catalog shape added in this commit (low/medium/high), this returns high, even though requesting xhigh on the same model returns Claude Code's supported max; selecting the nominally stronger setting therefore silently reduces effort. Add a direct max mapping for these known max-backed models rather than clamping it through the advertised ladder.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant