Skip to content

Add Pattern match completeness for zipColumns #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mchav merged 1 commit into from
Aug 5, 2025
Merged

Add Pattern match completeness for zipColumns #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/DataFrame/Internal/Column.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,16 @@ reduceColumn _ _ = error "UNIMPLEMENTED"
zipColumns :: Column -> Column -> Column
zipColumns (BoxedColumn column) (BoxedColumn other) = BoxedColumn (VG.zip column other)
zipColumns (BoxedColumn column) (UnboxedColumn other) = BoxedColumn (VB.generate (min (VG.length column) (VG.length other)) (\i -> (column VG.! i, other VG.! i)))
zipColumns (BoxedColumn column) (OptionalColumn optcolumn) = BoxedColumn (VG.zip (VB.convert column) optcolumn)

zipColumns (UnboxedColumn column) (BoxedColumn other) = BoxedColumn (VB.generate (min (VG.length column) (VG.length other)) (\i -> (column VG.! i, other VG.! i)))
zipColumns (UnboxedColumn column) (UnboxedColumn other) = UnboxedColumn (VG.zip column other)
zipColumns (UnboxedColumn column) (OptionalColumn optcolumn) = BoxedColumn (VG.zip (VB.convert column) optcolumn)

zipColumns (OptionalColumn optcolumn) (BoxedColumn column) = BoxedColumn (VG.zip optcolumn (VB.convert column))
Copy link
Copy Markdown
Member

@mchav mchav Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Optional columns are boxed vectors. So no need to convert here.

zipColumns (OptionalColumn optcolumn) (UnboxedColumn column) = BoxedColumn (VG.zip optcolumn (VB.convert column))
zipColumns (OptionalColumn optcolumn) (OptionalColumn optother) = BoxedColumn (VG.zip optcolumn optother)

zipColumns _ _ = error "Zip is unimplemented"
{-# INLINE zipColumns #-}

Expand Down Expand Up @@ -663,4 +671,4 @@ toVectorSafe (GroupedUnboxedColumn (col :: VB.Vector b)) =
, expectedType = Right (typeRep @b)
, callingFunctionName = Just "toVectorSafe"
, errorColumnName = Nothing})
toVectorSafe _ = error "Cannot convert mutable column to vector"
toVectorSafe _ = error "Cannot convert mutable column to vector"