Add Pattern match completeness for zipColumns#52
Merged
mchav merged 1 commit intoDataHaskell:mainfrom Aug 5, 2025
Merged
Conversation
The current `zipColumns` implementation lacks support for OptionalColumn types. A refactor was done for zipColumn function be able to handle those cases. mchav#48
fserucas
force-pushed
the
pattern-match-completeness-for-zip-columns-48
branch
from
d9bf878 to
baca97a
Compare
mchav
approved these changes
Aug 5, 2025
| zipColumns (UnboxedColumn column) (UnboxedColumn other) = UnboxedColumn (VG.zip column other) | ||
| zipColumns (UnboxedColumn column) (OptionalColumn optcolumn) = BoxedColumn (VG.zip (VB.convert column) optcolumn) | ||
|
|
||
| zipColumns (OptionalColumn optcolumn) (BoxedColumn column) = BoxedColumn (VG.zip optcolumn (VB.convert column)) |
Member
There was a problem hiding this comment.
nit: Optional columns are boxed vectors. So no need to convert here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
zipColumnsimplementation lacks support for OptionalColumn types. A refactor was done for zipColumn function be able to handle those cases. mchav#48