Config visibility report all sources and their values#268
Conversation
BenchmarksBenchmark execution time: 2025-12-23 18:53:58 Comparing candidate commit 382e80f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
anna-git
force-pushed
the
anna/config-visibility-report-all
branch
from
3c24a75 to
1c55cd9
Compare
anna-git
changed the title
include/datadog/config.h
Outdated
| // The fallback parameter is optional and defaults to nullptr. | ||
| template <typename Value, typename Stringifier = std::nullptr_t, | ||
| typename DefaultValue = std::nullptr_t> | ||
| Value pick(const Optional<Value>& from_env, const Optional<Value>& from_user, |
There was a problem hiding this comment.
This function does more than just pick a value from a list anymore. Either the configuration chain should be structured differently, or the function should be renamed to better reflect its behavior.
There was a problem hiding this comment.
Good point, renamed to resolve_and_record_config it in 382e80f and improved documentation
bin/format
Outdated
| process_arg "$arg" | ||
| done | xargs -0 \ | ||
| docker run \ | ||
| --platform linux/amd64 \ |
There was a problem hiding this comment.
Is this change necessary? IIRC docker would use the right platform depending on the host platform.
There was a problem hiding this comment.
oh yes I was just getting WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested on my machine and added that but I can get rid of it
|
Just catching up on some PR's while I was on PTO, and this looks great! Nice work @anna-git |
4 participants
Description
Report all configuration sources to telemetry, even those who aren't applied, in order of precedence.
Motivation
For config visibility, report all sources set
Additional Notes
Jira ticket: [Enhanced Configuration Reporting]
Added one test and adapted one test.