Skip to content

run system-tests on pull requests#273

Merged
cbeauchesne merged 2 commits intomainfrom
cbeauchesne/run-parametric-on-pr
Jan 21, 2026
Merged

run system-tests on pull requests#273
cbeauchesne merged 2 commits intomainfrom
cbeauchesne/run-parametric-on-pr

Conversation

@cbeauchesne
Copy link
Contributor

@cbeauchesne cbeauchesne commented Jan 20, 2026

Description

  • Run system-tests on PR (previously only on push on main)
  • Optimize CI time
  • Use idiomatic parameters for system-tests workflow

Motivation

#268 introduced a bug on main, if system-tests were executed on PR, this would have prevented the bug to reach main. It caused many rework to fix the issue.

CI on PR already last for more than 7mn (example). This job, with the parameter parametric_job_count last for ~5mn. so this new job want slow down the CI process.

(I restarted the sub-job get parameters to get a real duration value, as the runner is cached, the first run had to compute it, but next one will use the cache))

Additional Notes

Jira ticket: [PROJ-IDENT]

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.83%. Comparing base (7a55843) to head (c2efa4a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          84       84           
  Lines        5664     5664           
=======================================
  Hits         4975     4975           
  Misses        689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2026

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 87.84% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c2efa4a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@cbeauchesne cbeauchesne requested a review from anna-git January 20, 2026 15:29
@cbeauchesne cbeauchesne marked this pull request as ready for review January 20, 2026 15:29
@cbeauchesne cbeauchesne requested a review from a team as a code owner January 20, 2026 15:29
@cbeauchesne cbeauchesne requested review from zacharycmontoya and removed request for a team January 20, 2026 15:29
@pr-commenter
Copy link

pr-commenter bot commented Jan 21, 2026

Benchmarks

Benchmark execution time: 2026-01-21 09:02:42

Comparing candidate commit c2efa4a in PR branch cbeauchesne/run-parametric-on-pr with baseline commit 7a55843 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Copy link
Contributor

@anna-git anna-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@cbeauchesne cbeauchesne merged commit ef6d81e into main Jan 21, 2026
38 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/run-parametric-on-pr branch January 21, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants