-
Notifications
You must be signed in to change notification settings - Fork 15
feat: endpoint renaming #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
57bc297
Fix bin/format to work on mac os
cataphract 6f07b40
Implement endpoint guessing
cataphract e766723
Address review comments; preserve final /
cataphract 45fd007
Suppress false positive from gcc
cataphract 097dd3b
Address review comments
cataphract e928c9f
Refactoring in component_replacement
cataphract 849fddb
Address final review comment
cataphract File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| #pragma once | ||
|
|
||
| // This component provides an enumeration that controls how the http.endpoint | ||
| // tag is calculated for HTTP spans. | ||
|
|
||
| #include <cstdint> | ||
|
|
||
| namespace datadog { | ||
| namespace tracing { | ||
|
|
||
| // `HttpEndpointCalculationMode` determines when and how the http.endpoint tag | ||
| // is inferred from http.url for HTTP spans. | ||
| // | ||
| // The http.endpoint tag provides a normalized, parameterized version of the | ||
| // HTTP path (e.g., "/users/{param:int}" instead of "/users/123"). This helps | ||
| // aggregate similar requests and reduce cardinality in monitoring systems. | ||
| enum class HttpEndpointCalculationMode : std::uint8_t { | ||
| // Do not calculate http.endpoint. The tag will not be set unless explicitly | ||
| // provided by the user. | ||
| DISABLED, | ||
|
|
||
| // Calculate http.endpoint from http.url only when http.route is not present. | ||
| // This mode acts as a fallback - if instrumentation provides http.route, | ||
| // use that; otherwise, infer http.endpoint from the URL path. | ||
| FALLBACK, | ||
|
|
||
| // Always calculate http.endpoint from http.url, even when http.route is | ||
| // present. Both tags will be set, allowing for comparison between | ||
| // user-provided routes and automatically inferred endpoints. | ||
| ALWAYS_CALCULATE, | ||
| }; | ||
|
|
||
| } // namespace tracing | ||
| } // namespace datadog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide some context on why this change is needed and what problem it aims to solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's described in the commit message. Essentially, it doesn't work correctly on Docker desktop on mac os