Merged
Conversation
cataphract
requested review from
zacharycmontoya
and removed request for
a team
cataphract
force-pushed
the
glopes/endpoint-renaming
branch
from
b352e56 to
251dfa6
Compare
cataphract
force-pushed
the
glopes/endpoint-renaming
branch
from
251dfa6 to
2d5c029
Compare
cataphract
force-pushed
the
glopes/endpoint-renaming
branch
from
2d5c029 to
33090c4
Compare
| REQUIRE(span.tags.count(tags::http_endpoint) == 0); | ||
| } | ||
|
|
||
| SECTION("pre-existing http.endpoint is preserved") { |
Contributor
There was a problem hiding this comment.
Is this behavior mandated by the RFC and/or enforced by other tracers? I don't see this described anywhere
Contributor
Author
There was a problem hiding this comment.
The RFC is silent on this. While http.endpoint should not be provided the user (unlike http.route, which may be), this option made most sense to me (maybe the value was already calculated/cached)
cataphract
force-pushed
the
glopes/endpoint-renaming
branch
from
b28c1ef to
6875131
Compare
src/datadog/endpoint_inferral.cpp
Outdated
|
|
||
| // is_str requires a special char or a size >= 20 | ||
| viable_components &= ~component_type::is_str | | ||
| bool2mask(found_special_char || (path.size() >= 20)); |
Contributor
There was a problem hiding this comment.
super small nit: Can we refactor into if statements to get rid of the bool2mask operation?
zacharycmontoya
approved these changes
Nov 18, 2025
For reasons I didn't explore further, /mnt/host/Users is shown in the directory listing of /mnt/host, but can't be traversed
Anilm3
approved these changes
Nov 19, 2025
| found_special_char = true; | ||
| viable_components &= | ||
| ~(component_type::is_int | component_type::is_int_id | | ||
| component_type::is_hex | component_type::is_hex_id); |
Contributor
There was a problem hiding this comment.
I don't see why you'd want continue after this point as there is no condition in which you remove strings as a viable component within the for loop and you've removed all other possibilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements RFC-1051: APM endpoint resource renaming
Motivation
Additional Notes
Jira ticket: APPSEC-58791