fix(api): RBAC default-deny + constant-time API key (#1133 #1134)#1143
Draft
FabioLeitao wants to merge 3 commits into
Draft
fix(api): RBAC default-deny + constant-time API key (#1133 #1134)#1143FabioLeitao wants to merge 3 commits into
FabioLeitao wants to merge 3 commits into
Conversation
When api.rbac is active, unclassified routes return 403; public allowlist covers health/static/webauthn/help/about/login. Add findings and OpenAPI doc routes to the role map.
Fail CI when a new app route lacks RBAC classification; assert rbac resolve path uses hmac.compare_digest for API keys.
hmac.compare_digest on str rejects non-ASCII and raised TypeError → 500. Encode provided/expected as UTF-8 bytes (constant-time, no-match → 401). Closes #1150
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.rbacis active (OSS/default unchanged). Public allowlist: health, static, WebAuthn auth routes, locale GET help/about/login. All data routes mapped; unclassified → 403. CI invariant: every registered FastAPI route ∈ public ∪ role map.resolve_effective_roles_for_requestuseshmac.compare_digest.X-API-Key/ Bearer values return 401 (notTypeError→ 500).Test plan
./scripts/check-all.shgreenpytest tests/test_rbac.py— 9/9 (incl. non-ASCII API key → 401)Closes #1133, #1134, #1150.