docs(cursor): two-tier check-all gate (local commit vs push/PR)#1156
Open
FabioLeitao wants to merge 4 commits into
Open
docs(cursor): two-tier check-all gate (local commit vs push/PR)#1156FabioLeitao wants to merge 4 commits into
FabioLeitao wants to merge 4 commits into
Conversation
When api.rbac is active, unclassified routes return 403; public allowlist covers health/static/webauthn/help/about/login. Add findings and OpenAPI doc routes to the role map.
Fail CI when a new app route lacks RBAC classification; assert rbac resolve path uses hmac.compare_digest for API keys.
hmac.compare_digest on str rejects non-ASCII and raised TypeError → 500. Encode provided/expected as UTF-8 bytes (constant-time, no-match → 401). Closes #1150
Clarify pre-commit and slice checks for local commits; full check-all only before git push, PR create, or merge publish to GitHub. Gate-Change-Approved-By: Fabio Tavares Leitão
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies check-all-gate.mdc: local commits use pre-commit + targeted tests; full
./scripts/check-all.sh(or--enforced) is required before push/PR/merge to GitHub — not before every local commit.Separate from RBAC (#1143) and Tier B (#1154).
Test plan
Gate-Change-Approved-By: Fabio Tavares Leitão
Made with Cursor