Skip to content

test(rate): add shared Ground and Tee parity fixture - #4325

Merged
dieterolson merged 4 commits into
feat/4181-launch-monitor-registryfrom
feat/4143-tee-parity-fixture
Aug 11, 2026
Merged

test(rate): add shared Ground and Tee parity fixture#4325
dieterolson merged 4 commits into
feat/4181-launch-monitor-registryfrom
feat/4143-tee-parity-fixture

Conversation

@d-sorgcodexagent

@d-sorgcodexagent d-sorgcodexagent Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add one versioned SI Ground/Tee golden fixture consumed directly by Python and React
  • pin driver/non-driver defaults, explicit overrides, Ground zero-effective-height behavior, derived ball geometry, serialization, and legacy Ground migration
  • fail closed in both runtimes for negative and non-finite tee heights
  • update all four canonical Rate of Closure handoffs and SPEC.md in the same commit

Advances the explicit Python/React parity acceptance criterion in #4143. Parent epic: #4142.

Verification

  • Python tee/parity suites: 18 passed; independent exact-head parity rerun: 5 passed
  • React tee/persistence/parity suites: 24 passed; independent exact-head parity rerun: 5 passed
  • TypeScript, ESLint, and Vite production build: passed
  • Ruff check/format, docs governance, changed-Python policy, assertion gate, changed-file size budget, and git show --check: passed
  • fixture SHA-256: 2d72886fbef22e64dfe048788a47db7e8f3d0fdbcccf874eb9b5a7be38ac01a5

Scope and remaining gates

This bounded parity slice does not close #4143. Recorded Playwright Ground/Tee visuals and equivalent PyQt rendered evidence now exist and match their recorded manifests. The Playwright captures currently live only in a local temporary evidence directory and still need a durable CI artifact or reproducible committed scenario. Protected current-head CI/review, parent-first dependency landing, and release to main remain open. The campaign manifest is absent from this exact #4203 lineage and was introduced later on a divergent branch, so it was not backported or recreated here.

PR #4203 currently remains a conflicting draft after its parent moved; this PR does not modify, retarget, or rewrite that parent. Dependency-ordered integration must wait for normal parent-first propagation.

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor Author

Exact-head hosted CI update: CI Standard quality gate completed successfully for 8050eebafd6222ab33aa3de09b61e19795ca10ca in run 31431692394, job 93596379517. The base branch subsequently advanced to repaired #4203 head 12dd76a8dbcc106c4683f2f2e53076f8dc6f1b76; the unchanged child therefore still requires normal parent propagation and a fresh mergeability/current-head review. Other checks remain queued. No merge or issue closure is authorized.

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor Author

2026-08-10 rendered Ground/Tee evidence and repaired-parent propagation

Current exact head f0f0dee074d29e3f12bf5f566c38d0080e43c756 now includes:

  • visual-evidence commit 36e38ac5dedfe380a887d32f9757d0030a59914a: deterministic 1600x1200 Playwright Driver/Tee and explicit-Ground captures with semantic control/diagram assertions and zero console/page errors; hidden 1400x900 PyQt captures with canonical center/editor/tee-artist assertions plus a nonblank, non-pixel-absolute regression;
  • normal merge of repaired feat(rate-of-closure): add launch monitor convention registry #4203 parent 12dd76a8dbcc106c4683f2f2e53076f8dc6f1b76, with no production/test-code conflict, rebase, retarget, force-push, or history rewrite.

External evidence manifests:

  • React SHA-256 43df78e04b47e1b3209ff7a574718f90847ccda6dde5afd863d43191a950ccf7
  • PyQt SHA-256 07822495dbcfa7568615ccb2728481210c28963614434c80f6997210c325a6f9

Verification includes 27 focused Ground/Tee Python tests, TypeScript/ESLint/Vite, Ruff/format, governance/assertion/changed-file/size/whitespace gates, an independent exact visual-regression rerun, and post-propagation shared-fixture/visual selection. Screenshots remain external rather than oversized repository binaries.

The earlier quality-gate success applied to old head 8050eeba…; fresh protected CI/review is required for this head. #4143 remains open until the dependency line lands on main.

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor Author

Exact-current-head hosted CI update: CI Standard quality gate completed successfully for f0f0dee074d29e3f12bf5f566c38d0080e43c756 in run 31433044253, job 93600754951. The only annotation is a warning that gitleaks is skipped because its license is not configured; the separate detect-secrets check remains queued. Other protected jobs and repository review remain open, so this is not merge or issue-closure authorization.

@dieterolson
dieterolson merged commit d1e5aa3 into feat/4181-launch-monitor-registry Aug 11, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant