Skip to content

test(rate): persist Ground Tee visual evidence - #4328

Closed
d-sorgcodexagent[bot] wants to merge 2 commits into
feat/4143-tee-parity-fixturefrom
test/4143-ground-tee-visual-evidence
Closed

test(rate): persist Ground Tee visual evidence#4328
d-sorgcodexagent[bot] wants to merge 2 commits into
feat/4143-tee-parity-fixturefrom
test/4143-ground-tee-visual-evidence

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Summary

  • add a path-filtered local-fleet Playwright workflow for the Rate of Closure React surface
  • prove Driver tee defaults and explicit Ground behavior with semantic assertions and deterministic screenshots
  • upload screenshots, SHA-256 evidence manifest, traces, and HTML report for 14 days
  • update the canonical specification and handoffs in the same commit

Verification

  • 526 Vitest tests passed
  • Playwright Ground/Tee scenario passed
  • TypeScript, zero-warning ESLint, and Vite production build passed
  • workflow policy, action pinning, YAML, documentation governance, and whitespace checks passed

Scope

This is a test-and-evidence-only child of #4325; it does not change physics or production behavior. It closes the durable visual-artifact gap identified in #4143, but #4143 remains open until the dependency stack lands through protected CI and review.

@dieterolson

Copy link
Copy Markdown
Collaborator

Superseded by #4466, which consolidates all 43 open src/rate_of_closure PRs into one
branch. Closing this one is measured, not assumed: verify_coverage.sh reports
safe=43 NOT-covered=0 against consolidated/rate-closure-remainder-2026-08-13, so this
PR's head is contained and nothing here is dropped.

Stacks were folded top-down (each child into its own parent, then the parent upward), so
non-tip work is included rather than skipped — including 8067ca79a (#4171, CAD export
artifact validation) and f9afa9d96 (#4309, strict ground result playback), each of which
lived in exactly one PR and is absent from its stack tip.

The consolidation also repairs defects the merge exposed, listed in #4466: two unguarded
datetime.UTC imports that break the Python 3.10 lane, a PyQt module registry that could no
longer construct the main window, the club-assembly binding and STL/sidecar controls that had
been dropped from the wired tree, and a filelock dependency that would have failed
tests (3.11) at collection.

Reopen this PR if you need its branch; the branch itself is untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant