feat(rate-of-closure): add responsive wind strategy workflow by d-sorgcodexagent[bot] · Pull Request #4282 · D-sorganization/Tools

d-sorgcodexagent · 2026-08-08T00:36:02Z

Summary

Completes the current-launch wind-strategy workflow slice of #4199 on top of the scalar-ensemble adapter in #4281.

Adds matched PyQt6 and React wind-strategy workspaces driven by the current launch and canonical spatial target.
Runs immutable paired ensembles off the GUI/main thread with exact progress, cooperative cancellation, teardown, and stale-result invalidation.
Exposes every declared scalar as an axis, cohort/status availability, risk summaries, captured calculation basis, and null-preserving formula-neutralized all-row CSV export.
Adds native/custom zoom, Auto Fit, reset history, and movable/hidden legend controls.
Adds accessible ball-flight looping with one owned timer/animation frame.
Compacts the PyQt setup into a two-column Setup view and automatically selects the plot-first Results view on completion.
Updates both repository handoffs with the ground/parity audit contracts and capability-observer continuation.

Root cause and design

The shared wind analysis and scalar adapter existed, but neither user surface had a responsive, lifecycle-safe execution workflow. Long runs would otherwise tempt GUI-thread execution, and results could silently become stale after launch, target, model, or uncertainty edits. This change builds each run from an immutable captured request, streams bounded progress, publishes only a complete non-stale result, and keeps unavailable values explicit.

Validation

Python/PyQt/shared swing: 1,350 passed, 5 skipped, 15 warnings.
React: 94 files / 566 tests passed.
Rust swing core: 12 passed.
Ruff, Black, targeted mypy, TypeScript, zero-warning ESLint, and git diff checks passed.
Production Vite build: 175 modules; wind worker and Wind Strategy workspace remain separate chunks; main chunk 472.58 kB with no size warning.
All 19 changed production modules are at most 400 physical lines.
Live PyQt QA at 1280x768: separate flight plots, continuous Loop playback through landing, five-trial wind run completed 5/5, calculation basis/summary/scatter/Auto Fit/native pan-zoom/legend controls visible without overlap.

The five Python skips are the optional local swing_core/tools_core wheel fast paths. The warnings are the existing Hypothesis norecursedirs warning and empty polynomial-preview legend warning. The in-app browser refused localhost navigation under its URL policy, so React UI evidence is the complete component suite and production build rather than a claimed live-browser pass.

Carrier consolidation (2026-08-09)

This branch now also carries the already-merged capability observer/evaluator/workspace stack plus release hardening needed to validate the composed campaign: strict workflow parsing, complete capability result exports, stable React launch entrypoints, deterministic campaign manifest/schema authority, launcher-policy compliance, and exact changed-file typing fixes. The original wind acceptance remains intact.

Current exact-head evidence (de49580a3): Python 3.12/mypy 1.13 passes all 54 changed files; Ruff, documentation governance, changed-Python policy, manifest validation, 62 focused regression tests, and eight campaign-manifest tests pass locally. The protected hosted quality-gate also passes on this exact head. Other protected jobs remain runner-queued and are not yet treated as validation.

Stack

Base: feat/4199-wind-scalar-adapter / #4281
Head: feat/4199-wind-workflow / de49580a3

This PR is intentionally draft and stacked. Do not retarget, force-push, or merge ahead of its parent.

github-actions · 2026-08-08T02:10:00Z

⚠️ SPEC.md Update Required

Source files were modified in this PR but SPEC.md was not updated.

Per the Specification-Driven Development Policy:

Any PR that adds, removes, or changes functionality must update SPEC.md
Update the relevant sections (features, architecture, tests, dependencies, etc.)
Bump the Spec Version if making substantive changes

To resolve:

Update SPEC.md to reflect your changes, OR
Add the spec-exempt label if this PR genuinely doesn't affect the spec (e.g., pure refactor with no behavior change)

This check is enforced by the spec-check CI workflow.

…n workspaces Expose the qualified Waterloo/Penner capability optimizer as a primary Shot Optimizer module in both clients: strict cross-runtime capability-optimization-workflow/v1 authoring and persistence, off-UI-thread execution with truthful progress and cooperative cancellation, complete scalar-ensemble/v1 cohort retention, ranked alternatives, stage-qualified scatter axes, bounded raw-row paging, spreadsheet-safe CSV, and stable JSON. The React panel is lazy-loaded so the main Vite chunk stays under the 500 kB warning threshold, and saved v1 layouts reveal newly registered modules. Handoff documents are updated in this implementation commit per fleet policy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…t reveal Add PyQt workflow/worker/GUI suites and React workflow, worker-client, run, panel, and results tests for the Shot Optimizer slice; extend primary-navigation coverage so saved layouts reveal newly registered modules and the new tab registers exactly once in both clients. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

… gates Add the SPEC 1.14.6 change-log row, document the end-user workflow in the capability optimization spec, and update the campaign handoff with the recovered slice and its verified gate evidence. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

No material source change; handoff pointer update only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…cess The dict-splat construction of CapabilityWorkflowInputs failed the hosted delta-mypy gate because **dict[str, float] cannot be proven against the integer fields. Build the snapshot with explicit typed keyword arguments instead; behavior is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Handoff update for implementation commit 101020b per fleet policy; no source change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The prior note wrongly framed the 3.10 StrEnum ImportError as a stack-wide defect to fix in source. requires-python is >=3.11 and only quality-gate and tests (3.11) are required checks, so the 3.10 lane is a stale-matrix artifact. No source change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The observation contract has only complete/no_impact/failed members, so a horizon nonconvergence is normalized into failed. Reporting a bare "failed N" reads as numerical breakage when the retained reason says the flight simply did not reach the ground inside the configured horizon. Both clients now append the retained reason codes with counts, which is data the adapter already carries per row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

A descending launch starts at z=0 and is already below ground once the t > dt guard permits the crossing check, so the interpolation ratio went negative and extrapolated the crossing to a negative sample time. That raised RangeError: timeS must be nonnegative, which the observation layer absorbed as an untyped evaluator_exception on 12 of 96 samples of a default driver search while Python reported none. Clamping the ratio to [0, 1] keeps the crossing inside the detecting step, so these samples report nonconverged and match the Python runtime. Also builds _lerp_vector's 3-tuple explicitly instead of carrying an unused type: ignore, and coerces _curve to float, clearing the hosted delta-mypy gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Brings in the evaluator branch descending-launch and delta-mypy repairs. Resolves the two documentation conflicts by keeping both slices: SPEC.md retains the 1.14.6 workspace row above the amended 1.14.5 evaluator row at header version 1.14.6, and the tool handoff keeps the workspace completion record ahead of the evaluator repair entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat(rate-of-closure): matched PyQt6/React capability optimization workspaces

feat(rate-of-closure): bind optimizer to full flight

feat(rate-of-closure): stream capability optimizer samples

The per-slice stacked-branch cautions described the stack while it was open and now read as active constraints, so state plainly that #4283, #4289, and #4294 are merged onto this branch, how they were folded, what was verified here (1426 Python, 624 React), and that the incomplete CI matrix reflects 25 of 28 org runners being offline rather than failures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

d-sorgcodexagent · 2026-08-09T22:42:17Z

Exact-head stabilization update for a742ad6cc2853b170eb945c4d74a56ea23bdda33:

strict cross-runtime capability-workflow primitive validation plus reliable signed-decimal input
complete PyQt6/React ranked diagnostics, units, result CSV/JSON, and quantitative React scatter scales/legends
package-safe direct web launcher, truthful static-Vite/PyQt6 release surfaces, and removal of unsupported Tauri declarations
strict rate-of-closure-campaign/v1 release-evidence manifest, validator, schema, tests, and current-state handoffs
launcher bootstrap now satisfies changed-production-Python policy without launcher-local sys.path mutation

Local exact-head evidence: 836 Rate Python/PyQt tests passed; 104 React files / 642 tests passed; TypeScript, zero-warning ESLint, 188-module Vite build, Ruff, targeted mypy, docs governance, changed-Python policy, manifest/schema validation, and focused launcher/parity contracts passed.

This PR remains draft. The new hosted checks are queued/in progress and there is no review approval; no readiness or merge claim is being made. The checked-in manifest is a deterministic observed snapshot, so live PR heads must still be re-queried before any merge or issue closure.

…9-wind-workflow # Conflicts: # AGENT_HANDOFF.md # SPEC.md # docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md # src/rate_of_closure/AGENT_HANDOFF.md

# Conflicts: # AGENT_HANDOFF.md # SPEC.md # docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md # src/rate_of_closure/AGENT_HANDOFF.md # tests/rate_of_closure/test_python_compatibility.py

d-sorgcodexagent · 2026-08-10T21:34:22Z

Exact-parent propagation update (2026-08-10):

Published head: 1e82f15026786ea0b08f78f4c001590ddce9ff39
Merge parents, in order: prior child 686016196a2f895058b8a566dff103a0fd32cd10, repaired scalar-adapter parent d6fb04e07c2a625412e9208b07103acdc42c621b
Branch/base preserved: feat/4199-wind-workflow -> feat/4199-wind-scalar-adapter
Draft state preserved; no rebase, retarget, force-push, parent rewrite, or merge
Conflict scope was limited to the four canonical handoff/spec files; no wind-workflow production or test code conflicted
Local evidence: 25 focused D-plane/impact tests passed before final documentation-only conflict resolution; documentation governance passed; changed-file size budget passed (0 violations); staged whitespace/conflict-marker checks passed
Canonical handoffs and SPEC.md were updated in the same merge commit

Fresh exact-head protected CI is now running. Do not propagate this head into #4285 until the required quality gate is green; queued checks are not validation.

…9-wind-workflow # Conflicts: # AGENT_HANDOFF.md # SPEC.md

dieterolson · 2026-08-13T16:36:02Z

Consolidated into #4410. Closing to eliminate CI runner load.

dieterolson added 4 commits August 7, 2026 17:34

feat(rate-of-closure): add responsive wind strategy workflow

fdcc250

docs(rate-of-closure): record wind workflow PR

727c690

fix(rate-of-closure): align wind panel Qt lifecycle typing

424b4c3

docs(rate-of-closure): record CI repair and parity audits

6e3c102

d-sorgcodexagent Bot mentioned this pull request Aug 8, 2026

[Ball Flight] Model wind-estimate error and shot or club strategy distributions #4199

Open

dieterolson added 2 commits August 7, 2026 19:10

feat(rate-of-closure): stream capability optimizer samples

43ad5e3

fix(rate-of-closure): harden capability observation parity

5c6073b

d-sorgcodexagent Bot mentioned this pull request Aug 8, 2026

feat(rate-of-closure): stream capability optimizer samples #4283

Merged

docs(rate-of-closure): record capability observer PR

b632cb4

d-sorgcodexagent Bot mentioned this pull request Aug 8, 2026

[Ball Flight] Optimize shot design for player capability, distance, and dispersion #4197

Open

dieterolson and others added 19 commits August 7, 2026 20:08

fix(rate-of-closure): type capability attempt count

60ac5b4

ci: annotate capability parity digests

4961294

feat(rate-of-closure): bind optimizer to full flight

c280407

docs(rate-of-closure): record PR 4294 and ready-for-review stack state

409b818

No material source change; handoff pointer update only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs(rate-of-closure): record CI mypy repair and 3.10 StrEnum risk

1708dd9

Handoff update for implementation commit 101020b per fleet policy; no source change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Merge PR #4294: matched PyQt6/React capability optimization workspaces

43e13bb

feat(rate-of-closure): matched PyQt6/React capability optimization workspaces

Merge PR #4289: model-backed capability flight evaluator

9bbb98e

feat(rate-of-closure): bind optimizer to full flight

Merge PR #4283: capability observation stream and cancellation

c1827bb

feat(rate-of-closure): stream capability optimizer samples

fix(ci): isolate swing-core parity pytest plugins

18fe892

fix(rate-of-closure): harden capability workflow inputs

83fee94

dieterolson added 4 commits August 9, 2026 15:26

feat(rate-of-closure): expose capability diagnostics

7a1830b

fix(rate-of-closure): stabilize web release entrypoints

2a1ce9e

feat(rate-of-closure): add campaign release manifest

2c1a77b

fix(rate-of-closure): satisfy launcher policy

a742ad6

dieterolson added 5 commits August 9, 2026 15:55

fix(rate): satisfy exact changed-file type gate

de49580

Merge commit '958770049f0124dac0426a6dd62fd4edbf437e7a' into feat/419…

bb101ce

…9-wind-workflow # Conflicts: # AGENT_HANDOFF.md # SPEC.md # docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md # src/rate_of_closure/AGENT_HANDOFF.md

merge: propagate workspace timestamp fix into wind workflow

5f77af4

# Conflicts: # AGENT_HANDOFF.md # SPEC.md # docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md # src/rate_of_closure/AGENT_HANDOFF.md # tests/rate_of_closure/test_python_compatibility.py

merge: propagate wind adapter into responsive workflow

aa6eeff

fix(rate): type validated campaign manifest

6860161

d-sorgcodexagent Bot mentioned this pull request Aug 10, 2026

feat(rate-of-closure): adapt wind trials to scalar ensembles #4281

Closed

merge: propagate wind adapter repair into workflow

1e82f15

codex-scheduled added 3 commits August 11, 2026 02:40

style/fix: pre-commit automated fixes

29e15d6

merge(rate-of-closure): propagate wind adapter into workflow

b2baf6e

merge(rate-of-closure): propagate wind adapter into workflow

3faf9e9

d-sorgcodexagent Bot marked this pull request as ready for review August 11, 2026 19:00

d-sorgcodexagent Bot requested a review from dieterolson as a code owner August 11, 2026 19:00

codex-scheduled added 2 commits August 11, 2026 15:54

Merge commit 'e934ba563a79bf95ee892fea8593972c81299eeb' into feat/419…

8c6105d

…9-wind-workflow # Conflicts: # AGENT_HANDOFF.md # SPEC.md

merge(rate-of-closure): refresh wind workflow parent

5103369

dieterolson closed this Aug 13, 2026

Navigation Menu

Uh oh!

feat(rate-of-closure): add responsive wind strategy workflow - #4282

feat(rate-of-closure): add responsive wind strategy workflow#4282
d-sorgcodexagent[bot] wants to merge 41 commits into
feat/4199-wind-scalar-adapterfrom
feat/4199-wind-workflow

d-sorgcodexagent Bot commented Aug 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 8, 2026

Uh oh!

d-sorgcodexagent Bot commented Aug 9, 2026

Uh oh!

d-sorgcodexagent Bot commented Aug 10, 2026

Uh oh!

dieterolson commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

d-sorgcodexagent Bot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause and design

Validation

Carrier consolidation (2026-08-09)

Stack

Uh oh!

github-actions Bot commented Aug 8, 2026

⚠️ SPEC.md Update Required

Uh oh!

d-sorgcodexagent Bot commented Aug 9, 2026

Uh oh!

d-sorgcodexagent Bot commented Aug 10, 2026

Uh oh!

dieterolson commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

d-sorgcodexagent Bot commented Aug 8, 2026 •

edited

Loading