Skip to content

feat(rate-of-closure): adapt wind trials to scalar ensembles - #4281

Closed
d-sorgcodexagent[bot] wants to merge 13 commits into
feat/4144-variation-export-continuationfrom
feat/4199-wind-scalar-adapter
Closed

feat(rate-of-closure): adapt wind trials to scalar ensembles#4281
d-sorgcodexagent[bot] wants to merge 13 commits into
feat/4144-variation-export-continuationfrom
feat/4199-wind-scalar-adapter

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Outcome

Adds the first UI-neutral #4199 integration slice without changing the existing flight physics:

  • exact Python/React scalar-ensemble/v1 wire contract;
  • structured provenance, labeled stages/categories/cohorts, unit-bearing variables, RFC3986 composite row IDs, immutable nullable trials, and exact scatter availability;
  • pure wind-strategy adapters retaining completed, nonconverged, and invalid outcomes;
  • true/estimated wind, launch/aim, target, actual/perfect-information landing, miss, cost, and information-delta scalars;
  • fail-closed request/analysis agreement and deterministic scenario-provenance validation;
  • explicit test that React adaptation never calls the flight integrator.

This does not complete #4199. Background execution, cancellation/progress, client workflow, strategy/scatter views, persistence, and export wiring remain follow-up work.

Ground and parity tracking

Revalidates existing epics #4267 and #4260 rather than creating duplicates. Exact reuse, physical prerequisite, product-identity, and acceptance refinements are recorded in their 2026-08-07 comments and both Rate handoffs.

Verification

  • Python/PyQt/shared swing: 906 passed, 1 expected optional-Rust skip, 15 existing warnings
  • React: 91 files / 555 tests passed
  • Ruff check + format, Black, focused mypy: pass
  • TypeScript and zero-warning ESLint: pass
  • Vite production build: pass (166 modules)
  • git diff --check: pass
  • production Python files <400 lines; changed functions <=50 lines

Refs #4199
Refs #4144
Refs #4260
Refs #4267

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ SPEC.md Update Required

Source files were modified in this PR but SPEC.md was not updated.

Per the Specification-Driven Development Policy:

  • Any PR that adds, removes, or changes functionality must update SPEC.md
  • Update the relevant sections (features, architecture, tests, dependencies, etc.)
  • Bump the Spec Version if making substantive changes

To resolve:

  1. Update SPEC.md to reflect your changes, OR
  2. Add the spec-exempt label if this PR genuinely doesn't affect the spec (e.g., pure refactor with no behavior change)

This check is enforced by the spec-check CI workflow.

…9-wind-scalar-adapter

# Conflicts:
#	src/rate_of_closure/AGENT_HANDOFF.md
# Conflicts:
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
@d-sorgcodexagent

Copy link
Copy Markdown
Contributor Author

2026-08-10 repaired variation parent propagated normally

Exact repaired #4280 head b90e5021a59e2081415b51ef29fbed06377bc201 is now carried into this unchanged-base draft through merge commit d6fb04e07c2a625412e9208b07103acdc42c621b (parents: prior child 4a793c4c3f19aad43a3c215800b266be487ace49, then repaired parent). No rebase, retarget, force-push, or history rewrite occurred.

The merge tree had no scalar-adapter production/test conflict; only the four append-only handoff/SPEC surfaces required semantic reconciliation. The Python/TypeScript scalar-ensemble and wind-strategy adapter contracts are unchanged. Evidence after reconciliation: 25 focused D-plane, impact-contract, impact-kinematics, and impact-scene tests passed; docs governance, changed-file-size, and whitespace gates passed. Exact parent #4280 quality gate was green before propagation.

This PR remains draft. Fresh current-head protected CI, review, and dependency-order gates are required before any merge. Downstream #4282 and later children must receive this head only by later normal parent-first propagation.

@d-sorgcodexagent
d-sorgcodexagent Bot marked this pull request as ready for review August 11, 2026 19:00
codex-scheduled added 2 commits August 11, 2026 15:47
…9-wind-scalar-adapter

# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	src/rate_of_closure/AGENT_HANDOFF.md
@dieterolson

Copy link
Copy Markdown
Collaborator

Consolidated into #4410. Closing to eliminate CI runner load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant