Skip to content

fix: support omitDimensions for local embedding models#315

Open
yjjheizhu wants to merge 1 commit intoCortexReach:masterfrom
yjjheizhu:pr-264-clean
Open

fix: support omitDimensions for local embedding models#315
yjjheizhu wants to merge 1 commit intoCortexReach:masterfrom
yjjheizhu:pr-264-clean

Conversation

@yjjheizhu
Copy link

Summary

This PR is a clean replacement for #264 and keeps only the omitDimensions compatibility fix for local embedding models such as Qwen3/vLLM/Ollama.

What changed

  • add embedding.omitDimensions to the plugin config schema and UI metadata
  • parse and pass embedding.omitDimensions through plugin config loading
  • omit the dimensions field from embedding requests when omitDimensions: true
  • add a regression test to ensure the plugin manifest/schema stays in sync

Why

Some OpenAI-compatible local embedding endpoints reject requests that include the dimensions parameter. This makes the existing omitDimensions configuration necessary for compatibility, but it must be wired through config parsing and request construction to actually work.

Testing

  • node test/embedder-error-hints.test.mjs
  • node test/plugin-manifest-regression.mjs

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant