fix: local embedding model compatibility (Qwen3/vLLM/Ollama) + configurable rerank timeout#264
Conversation
- Test matryoshka representation error detection - Test unknown parameter: dimensions variant - Test dimensions not supported phrase variant - All verify omitDimensions hint is present
ee52e05 to
c5d96dc
Compare
|
I validated PR #264 locally with the OpenClaw harness. The main omitDimensions change works as expected, and both the host functional test and the real agent E2E passed. However, I found one issue in the same PR: rerankTimeoutMs was added in src/retriever.ts, but it is not declared in openclaw.plugin.json. Because retrieval uses additionalProperties: false, adding retrieval.rerankTimeoutMs to plugin config currently fails openclaw config validate with “must NOT have additional properties”. |
|
Thanks for the contribution! 🙏 There are currently merge conflicts with If you need any help with the rebase, feel free to ask! |
|
Hey @yjjheizhu, thanks for addressing the However, the latest commit (
Could you clean up the branch so only the changes related to this PR (omitDimensions + error hints) remain? A quick Let me know if you need a hand! |
|
Superseded by #315, which is the clean replacement PR containing only the omitDimensions fix and related schema/test updates. Closing this one to avoid merging the mixed-in unrelated changes and current merge conflicts. |
Summary
Fixes compatibility issues when using local embedding models (Qwen3, vLLM, Ollama) that don't support the
dimensionsparameter, and adds configurable rerank timeout for slow local rerank models.Changes
1. Add
omitDimensionsconfig switchembedding.omitDimensions: booleanoption (default: false)dimensionsparameter in embedding requests2. Friendly error hint for matryoshka errors
matryoshka,dimensions not supported,unknown param: dimensionsSet "embedding.omitDimensions": true in your config3. Configurable rerank timeout
retrieval.rerankTimeoutMs: numberoption (default: 5000)Testing
Breaking Changes
None — all changes are opt-in with sensible defaults.