test(config): preserve protected auth in runtime synthesis - #430
Draft
seonghobae wants to merge 10 commits into
Draft
seonghobae wants to merge 10 commits into
seonghobae wants to merge 10 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialized Runtime Configuration/authentication synthesis child for #140 / #310. Base remains exact Runtime Configuration owner
feat/runtime-config-bootstrap-snapshot@7d98725cc51b259b0be940385b2245758d098081; dependent PostgreSQL/trusted-proxy lanes remain parked until this child is integrated into #140.Current exact-head status — 2026-09-17 KST
Current head is
65b887e347d47e3cd29071342c353408c3f14e4a. The production synthesis is now present insrc/lib.rs; the temporary one-shot helper has been removed by ordinary fast-forward commit65b887e347d47e3cd29071342c353408c3f14e4aand is no longer part of the PR diff.The helper execution that produced the causal source repair is terminal GREEN: run
35160876925completedsuccessfrom exact helper inputcc8f721775e808ff00961dc8e29540e34720b1c2. It guarded the reviewed predecessor/protectedmain@f8260f1e03836039ff9463dd99fa982e4e270c4b, reconstructed from protected completesrc/lib.rs, applied only the Runtime Configuration/authentication composition, then passedcargo fmt,git diff --check,cargo test --locked --test runtime_configuration_auth_synthesis, andcargo test --locked --libbefore committing onlysrc/lib.rsas0e0f01efbd6e21874c94eed987192534e234f211.Fresh repository-owned evidence is now being reacquired on unchanged current head
65b887e...: CI run35180770661/rustjob105072217366and Fuzz run35180770659/fuzzjob105072216969are currently queued. Queued evidence is non-passing; predecessor GREEN is retained only as construction evidence and is not promoted to current-head admission evidence.Hostile RED → causal repair
Exact test-only head
062ea6ab787d0a1d864e429a95f7ed1642fbf37eestablished the defect: withBIND_ADDR=0.0.0.0:0and no write-capable administrator, stalerun_from_envactually bound the public listener and returned success. The same source left protected #155 authentication primitives unused, producing non-testdead_codewarnings rather than consuming them at the bootstrap boundary.The current source repairs that cause rather than suppressing symptoms:
RuntimeConfiguration::from_env()once;CredentialRegistry::bootstrap_from_env();ADMIN_TOKENS, rejecting blank entries/tokens, duplicate secrets, and unknown roles;require_write_auth_for_bind(&runtime.bind_addr, has_write_capable_admin)beforeTcpListener::bind;auth_modehealth/readiness evidence;401, authenticated-readonly403;The hostile contract remains explicit: public bind without a write-capable administrator fails closed; readonly-only bootstrap fails closed; a valid header-presentable writer permits bind. No second configuration/credential authority, source copy from foreign owners, cross-service SQL, mutable dependency, force push, destructive rebase, self/model approval, gate weakening, or routine bypass is introduced.
The PR stays Draft until the unchanged
65b887e...head receives fresh repository-native CI/Fuzz GREEN and then-current security/review/thread/base evidence. After that, merge normally into #140 and non-force-restack dependents; do not move the PostgreSQL chain beforehand.