feat(ui): strengthen admin console accessibility landmarks - #127
feat(ui): strengthen admin console accessibility landmarks#127seonghobae wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough관리 콘솔에 스크린 리더 안내, 섹션 탐색, 포커스 가능한 스킵 링크 대상, KPI 상태 알림을 추가했습니다. 주요 카드에 탐색용 식별자와 접근성 제목 연결을 적용했습니다. 관련 접근성 테스트도 추가했습니다. Changes관리 콘솔 접근성
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds accessibility landmarks, skip-target behavior, guidance text, and live-region semantics without altering routing, authorization, stored state, or runtime dependencies; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fresh repair-first state (2026-09-05 KST): converted to Draft. Exact head |
Scope
Strengthen the embedded admin console accessibility surface by adding navigable landmarks, a focusable skip target, explicit password-input labelling/help text, and atomic KPI live-region semantics. The change remains presentation/accessibility-only; it does not change management authorization or domain state.
Current integration state
This PR remains intentionally Draft because browser-level UI acceptance evidence is still missing. The branch was non-destructively restacked onto protected
main@5829a0f08d78de464dd24393ce5d0f25fba9d126with merge commit35f4b7a261c15f4549f8e77f40688adc4bb501b0; no force push or destructive rebase was used. Fresh comparison reportsbehind_by=0, merge base exactly equal to protected main, and the effective protected-main-relative delta remains onlysrc/lib.rs(+40/-9). The protected #159 CI/Fuzz queue foundation is therefore adopted without becoming part of this UI feature delta.All predecessor workflow conclusions are historical after this head movement. Current review findings must be revalidated against exact
35f4b7a261c15f4549f8e77f40688adc4bb501b0before integration.UI delivery evidence still required
The repository has product-design/Figma briefs for the embedded console but still lacks a production-like browser acceptance lane for this candidate. Source-string regressions alone are insufficient for material UI/accessibility work. Before this PR becomes Ready, exact-current-head evidence must cover:
Wardnet's console is embedded server-rendered HTML rather than a component-library SPA. Do not add decorative Storybook infrastructure solely to satisfy a label; use reusable product-design tokens/briefs plus a real browser E2E harness that exercises the shipped route. If later UI work establishes reusable browser components, Storybook can become the canonical component evidence surface then.
Merge boundary
Do not mark Ready or merge solely because Rust/source checks become GREEN. This candidate requires current-head real-browser interaction/accessibility evidence, zero valid unresolved review findings, current protected-base compatibility, and the ordinary then-live repository/security/review/governance gates. No self/model approval, routine bypass, force push, gate weakening, or predecessor evidence reuse.