Skip to content

feat(ui): strengthen admin console accessibility landmarks - #127

Draft
seonghobae wants to merge 5 commits into
mainfrom
codex/main-admin-a11y
Draft

feat(ui): strengthen admin console accessibility landmarks#127
seonghobae wants to merge 5 commits into
mainfrom
codex/main-admin-a11y

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Scope

Strengthen the embedded admin console accessibility surface by adding navigable landmarks, a focusable skip target, explicit password-input labelling/help text, and atomic KPI live-region semantics. The change remains presentation/accessibility-only; it does not change management authorization or domain state.

Current integration state

This PR remains intentionally Draft because browser-level UI acceptance evidence is still missing. The branch was non-destructively restacked onto protected main@5829a0f08d78de464dd24393ce5d0f25fba9d126 with merge commit 35f4b7a261c15f4549f8e77f40688adc4bb501b0; no force push or destructive rebase was used. Fresh comparison reports behind_by=0, merge base exactly equal to protected main, and the effective protected-main-relative delta remains only src/lib.rs (+40/-9). The protected #159 CI/Fuzz queue foundation is therefore adopted without becoming part of this UI feature delta.

All predecessor workflow conclusions are historical after this head movement. Current review findings must be revalidated against exact 35f4b7a261c15f4549f8e77f40688adc4bb501b0 before integration.

UI delivery evidence still required

The repository has product-design/Figma briefs for the embedded console but still lacks a production-like browser acceptance lane for this candidate. Source-string regressions alone are insufficient for material UI/accessibility work. Before this PR becomes Ready, exact-current-head evidence must cover:

  • keyboard skip navigation, target focus, and visible focus state;
  • accessible name/description computation for the credential input and affected controls;
  • KPI live-region semantics without duplicate/noisy announcements;
  • narrow, intermediate, and desktop widths without clipping/overlap;
  • normal plus applicable loading, error, and permission states;
  • WCAG 2.2 AA keyboard/focus/name/role/value expectations.

Wardnet's console is embedded server-rendered HTML rather than a component-library SPA. Do not add decorative Storybook infrastructure solely to satisfy a label; use reusable product-design tokens/briefs plus a real browser E2E harness that exercises the shipped route. If later UI work establishes reusable browser components, Storybook can become the canonical component evidence surface then.

Merge boundary

Do not mark Ready or merge solely because Rust/source checks become GREEN. This candidate requires current-head real-browser interaction/accessibility evidence, zero valid unresolved review findings, current protected-base compatibility, and the ordinary then-live repository/security/review/governance gates. No self/model approval, routine bypass, force push, gate weakening, or predecessor evidence reuse.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 57a73fa1-e81f-4909-8eb8-41bd731ba29d

📥 Commits

Reviewing files that changed from the base of the PR and between 1071176 and aa29565.

📒 Files selected for processing (1)
  • src/lib.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

관리 콘솔에 스크린 리더 안내, 섹션 탐색, 포커스 가능한 스킵 링크 대상, KPI 상태 알림을 추가했습니다. 주요 카드에 탐색용 식별자와 접근성 제목 연결을 적용했습니다. 관련 접근성 테스트도 추가했습니다.

Changes

관리 콘솔 접근성

Layer / File(s) Summary
접근성 구조와 상태 안내
src/lib.rs
스크린 리더 전용 스타일, 관리자 토큰 도움말, 섹션 탐색, 포커스 가능한 main, KPI role="status" 및 live region 속성을 추가했습니다. 주요 카드에 idaria-labelledby를 추가했습니다.
접근성 동작 검증
src/lib.rs
섹션 landmark, 스킵 링크 대상, 토큰 도움말 연결, KPI live region 속성을 검증하는 테스트를 추가했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to aa295

This change adds accessibility landmarks, skip-target behavior, guidance text, and live-region semantics without altering routing, authorization, stored state, or runtime dependencies; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 관리자 콘솔의 접근성 랜드마크 개선이라는 주요 변경 사항을 정확하고 간결하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/main-admin-a11y

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Devin Review

Comment thread src/lib.rs
Comment thread src/lib.rs
@seonghobae
seonghobae marked this pull request as draft September 4, 2026 18:54

Copy link
Copy Markdown
Contributor Author

Fresh repair-first state (2026-09-05 KST): converted to Draft. Exact head 4e160077a6b163b03af65dfd16ac2a722dcbfbae is based on obsolete main@b2bcee3bf2c63f26c48e3be879e5349ef23fafcd, while protected truth is main@5829a0f08d78de464dd24393ce5d0f25fba9d126; moreover this material UI/accessibility slice still lacks the required current-head real-browser evidence. Preserve the landmark/skip-target/label/help/live-region delta, but rebuild non-force from current protected UI/auth truth and add production-like E2E for keyboard skip/focus, computed accessible name/description, KPI live-region behavior, normal/loading/error/permission states, and narrow/intermediate/desktop layouts under WCAG 2.2 AA. Source-string tests alone are not merge evidence. No predecessor check/review transfer or decorative Storybook substitute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants