feat(reviewer): enforce actionable finding contract - #549
Merged
seonghobae merged 4 commits intoSep 4, 2026
Merged
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
…rca' into codex/noema-actionable-finding-contract Signed-off-by: Seongho Bae <me@seonghobae.me> # Conflicts: # reviewer/noema_reviewer/agent.py
Signed-off-by: Seongho Bae <me@seonghobae.me>
…rca' into codex/noema-actionable-finding-contract Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
September 4, 2026 10:13
seonghobae
merged commit Sep 4, 2026
0a6fac8
into
codex/noema-failed-check-source-rca
2 of 5 checks passed
Contributor
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence-based gap
PR #546 fails closed on empty or forged CodeGraph semantics. PR #548 binds each failed check to its own current-head
path:lineRCA. Neither changes the canonicalFindingoutput contract: a model could still omit priority, evidence type, observable impact, trigger, and an exact regression command, while a fenced suggestion in a top-level review body would not be directly applicable.This stack addresses that one remaining root gap without changing central workflows or concurrency.
Repair
path:lineis a right-side anchor in the exact current-head diffcommentspayload as an applyablesuggestioncheck_namecausal bindingVerification
uv run --project reviewer pytest -q->509 passeduv run --project reviewer interrogate -q reviewer/noema_reviewer-> passeduv run --project reviewer python -m compileall -q reviewer/noema_reviewer-> passedgit diff --check origin/codex/noema-failed-check-source-rca...HEAD-> passedNo central
.githubworkflow or concurrency file is changed. This is a stacked product PR; do not use admin bypass.