Skip to content

feat(reviewer): enforce actionable finding contract - #549

Merged
seonghobae merged 4 commits into
codex/noema-failed-check-source-rcafrom
codex/noema-actionable-finding-contract
Sep 4, 2026
Merged

feat(reviewer): enforce actionable finding contract#549
seonghobae merged 4 commits into
codex/noema-failed-check-source-rcafrom
codex/noema-actionable-finding-contract

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Evidence-based gap

PR #546 fails closed on empty or forged CodeGraph semantics. PR #548 binds each failed check to its own current-head path:line RCA. Neither changes the canonical Finding output contract: a model could still omit priority, evidence type, observable impact, trigger, and an exact regression command, while a fenced suggestion in a top-level review body would not be directly applicable.

This stack addresses that one remaining root gap without changing central workflows or concurrency.

Repair

  • make P1/P2/P3, evidence type, observable impact, trigger, smallest fix, and exact regression command typed finding data rather than prompt-only prose
  • reject multiline/Markdown-breaking regression commands and suggestion fence injection
  • accept suggested replacement text only when path:line is a right-side anchor in the exact current-head diff
  • publish valid replacement text through GitHub's inline review comments payload as an applyable suggestion
  • preserve fix(reviewer): bind failed checks to actionable source evidence #548's exact failed-check check_name causal binding

Verification

  • uv run --project reviewer pytest -q -> 509 passed
  • uv run --project reviewer interrogate -q reviewer/noema_reviewer -> passed
  • uv run --project reviewer python -m compileall -q reviewer/noema_reviewer -> passed
  • git diff --check origin/codex/noema-failed-check-source-rca...HEAD -> passed

No central .github workflow or concurrency file is changed. This is a stacked product PR; do not use admin bypass.

Signed-off-by: Seongho Bae <me@seonghobae.me>
…rca' into codex/noema-actionable-finding-contract

Signed-off-by: Seongho Bae <me@seonghobae.me>

# Conflicts:
#	reviewer/noema_reviewer/agent.py
Signed-off-by: Seongho Bae <me@seonghobae.me>
…rca' into codex/noema-actionable-finding-contract

Signed-off-by: Seongho Bae <me@seonghobae.me>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review September 4, 2026 10:13
@seonghobae
seonghobae merged commit 0a6fac8 into codex/noema-failed-check-source-rca Sep 4, 2026
2 of 5 checks passed
@seonghobae
seonghobae deleted the codex/noema-actionable-finding-contract branch September 4, 2026 10:13
@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant