Skip to content

fix(reviewer): bind failed checks to actionable source evidence - #548

Draft
seonghobae wants to merge 94 commits into
mainfrom
codex/noema-failed-check-source-rca
Draft

fix(reviewer): bind failed checks to actionable source evidence#548
seonghobae wants to merge 94 commits into
mainfrom
codex/noema-failed-check-source-rca

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Scope

Noema reviewer failed-check evidence must bind every failed check to actionable current-head source evidence. Finding.line is a GitHub source identity and is admitted only as an exact positive integer or None. contextual-orchestrator provider/model routing and quarantine/security/outbound authority remain outside this PR.

Retained causal lineage includes independent failed-check/source binding, repository-bound Check Run → Actions Job mapping, annotation fallback, structured actionability, inline suggestions, the hosted 100% coverage edge repairs, and RED 6551a863... → production/cleanup 02ec9006... for exact Finding.line admission.

After #552 merged, ordinary two-parent/non-force restack 75f93fd5d16f3b56eafd0f12a0eabe14ee277766 preserved all 18 reviewer/doc delta files and adopted protected main@5b8e620dbb01a794c1a38535bbcc32e41a80d0df. No provider/model, retry/timeout, quarantine/security/outbound authority or required-gate threshold changed.

Current exact authority

  • protected/live base: main@5b8e620dbb01a794c1a38535bbcc32e41a80d0df;
  • exact PR head: 75f93fd5d16f3b56eafd0f12a0eabe14ee277766;
  • lifecycle: open / Draft / mergeable;
  • fresh exact-head patch-validator-image 34021025117, ci 34021025132, required Security Scan 34021025146, reviewer-ci 34021025111 are queued. Predecessor GREEN does not transfer.

Promote only after this unchanged exact head has terminal current gates and zero valid unresolved findings. No self-approval, force push/destructive rebase, gate weakening, or runner-allocation source churn.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae
seonghobae marked this pull request as draft September 4, 2026 09:20
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/noema-failed-check-source-rca

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

* feat(reviewer): enforce actionable finding contract

Signed-off-by: Seongho Bae <me@seonghobae.me>

* test(reviewer): align causal findings with action contract

Signed-off-by: Seongho Bae <me@seonghobae.me>

---------

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from fix/codegraph-smoke-semantic-gate to main September 6, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant