Skip to content

fix(home): use customer-facing task and calendar status copy - #1578

Draft
seonghobae wants to merge 12 commits into
codex/desktop-unavailable-statefrom
codex/dashboard-user-facing-copy
Draft

fix(home): use customer-facing task and calendar status copy#1578
seonghobae wants to merge 12 commits into
codex/desktop-unavailable-statefrom
codex/dashboard-user-facing-copy

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Current authority — 2026-09-10

  • base: #1570@eadb882ffc8404f599f39068b74f90c6af38c80e
  • exact head: 1933963d1ed0a5f2d36e8be4238aa73a52982cb3
  • lifecycle: Draft / Today customer-copy descendant / do not merge
  • effective delta over current fix(home): expose retryable backend unavailable state #1570: exactly 4 files; fresh compare is ahead-only (behind_by=0).

Current head preserves predecessor #1578 as first parent and adopts repaired #1570 as second parent through non-force ordinary ancestry. The product delta remains the customer-facing task/calendar status copy plus its doctoring, component regression and dashboard E2E coverage; inherited security and release-note ownership remain with ancestors.

Pre-restack checks/reviews are predecessor evidence only. This exact head currently has no PR-triggered hosted workflow run.

UI Delivery Gate: FAIL

Intentionality/content scope are PASS. Current-head hosted execution, rendered responsive/keyboard evidence, applicable locale expansion checks and a qualifying post-restack independent review remain incomplete.

Replace implementation-facing captions without changing source fields, comparison semantics, or response guards. Preserve comparison-present and comparison-missing cases.

Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Capture present and absent comparison baselines only after the exact label enters the viewport. Runtime source is unchanged from ae5f39d.

Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Independent Visual Inspection completed for test-only head8b336829ca2bbf978103d1032836bbff7e01174b. Both implementation and coordinating agents directly opened all six newly generated present/absent comparison screenshots across desktop/tablet/mobile. Each target label and adjacent action is visible without observed clipping or overlap in inspected regions. Main also read the29-line E2E-only delta. The production runtime/build inputs are unchanged from ae5f39d; its existing build was reused, not represented as a newly run full build. Targeted tests6/6 in6.0s with pageerror assertions; original full484+sevenactwarnings belongs to ae5. Parent#1570 remains unmerged. No claim of all locales, real provider/authentication, translation-ledger delivery, or protected merge. Exact screenshot folders and capture procedure are in the updated PR body.

Preserve #1578's customer-facing dashboard copy and visual regression delta while inheriting #1570's canonical AGENTS ownership repair. No product or test delta is dropped.
@seonghobae seonghobae added bug Something isn't working priority: medium Normal-priority or P2 work status: draft Draft pull request type: bug Defect or incorrect behavior labels Sep 6, 2026 — with ChatGPT Codex Connector
@seonghobae

Copy link
Copy Markdown
Contributor Author

Fresh cross-PR visual evidence: #1599 mocked full-product smoke at app source877f0d5c produced desktop/mobile Home screenshots, and direct inspection found the source-linked task summary still customer-visible on that ancestor. This PR head6b807f0e3c4c8977559ac15898a454287c63eb7d replaces it with 미완료 and carries rendered/E2E negative assertions, so #1578 remains the canonical successor for this observed copy gap. Preserve this delta through its stack; do not duplicate it in #1599. The separate English Skip to main content text is owned by DashboardLayout and is not claimed fixed here. Exact-head checks/review and fresh visual inspection of #1578 remain required before merge.

…ilable-state' into codex/dashboard-user-facing-copy
@seonghobae

Copy link
Copy Markdown
Contributor Author

Non-force restack receipt: merged parent #1570 head 187f33255af4a73fce7a2508580c51cd75837f4c into this branch with an ordinary merge commit. Current exact head is 34fc2c83; the customer-copy delta remains intact. This PR stays Draft until #1570 reaches protected merge readiness.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review exact head f6648f8e63d1e00cc08502c0f60b5f1d64ad0252 only. This ordinary two-parent restack adopts repaired #1570 aeeda1ea... after the parent removed an unrelated AGENTS governance write. Verify the child still has exactly its four customer-copy/doctoring/E2E files, inherited parent recovery behavior is intact, and no AGENTS delta remains. Do not transfer predecessor review state.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='f6648f8e63d1e00cc08502c0f60b5f1d64ad0252'

echo '== Checked-out and requested commits =='
git rev-parse HEAD
git rev-parse "$head"
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$head"

echo
echo '== Parent commit details =='
for parent in $(git show -s --format=%P "$head"); do
  git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$parent"
  echo
done

parents=($(git show -s --format=%P "$head"))
first_parent="${parents[0]}"
second_parent="${parents[1]}"

echo '== Child-only delta: first parent -> exact head =='
git diff --name-status "$first_parent" "$head"
echo '-- stat --'
git diff --stat "$first_parent" "$head"

echo
echo '== Adopted-parent comparison: second parent -> exact head =='
git diff --name-status "$second_parent" "$head"
echo '-- stat --'
git diff --stat "$second_parent" "$head"

echo
echo '== Merge relationship =='
printf 'merge-base(first, second)='
git merge-base "$first_parent" "$second_parent"
printf 'merge-base(head, second)='
git merge-base "$head" "$second_parent"
git merge-base --is-ancestor "$second_parent" "$head" && echo 'second-parent-is-ancestor-of-head=yes'

echo
echo '== AGENTS paths differing from repaired parent =='
agents_diff="$(git diff --name-status "$second_parent" "$head" -- ':**/AGENTS*' ':AGENTS*')"
if [ -n "$agents_diff" ]; then
  printf '%s\n' "$agents_diff"
else
  echo 'none'
fi

echo
echo '== Candidate files in the first-parent delta =='
git diff --name-only "$first_parent" "$head"

echo
echo '== Source/test structure =='
for name in WorkspaceHome.tsx WorkspaceHome.dashboard.test.tsx dashboard-branding.spec.ts dashboard_customer_copy.md; do
  fd -a -t f -e tsx -e ts -e md -g "$name" . || true
done

echo
echo '== Outline source and test files =='
for f in $(fd -a -t f -g 'WorkspaceHome.tsx' -g 'WorkspaceHome.dashboard.test.tsx' -g 'dashboard-branding.spec.ts' .); do
  echo "-- $f --"
  ast-grep outline "$f" --items all || true
done

Length of output: 7660


🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='f6648f8e63d1e00cc08502c0f60b5f1d64ad0252'
first='34fc2c8399c233206c9aa73f3ac1668c50dc1a29'
repaired='aeeda1ea66b4c181bb01050b4bb469955ce00d0c'
parent_base='187f33255af4a73fce7a2508580c51cd75837f4c'

echo '== Four-file delta relative to repaired parent =='
git diff --find-renames --unified=40 "$repaired" "$head" -- \
  docs/doctoring/dashboard_customer_copy.md \
  frontend/src/components/WorkspaceHome.dashboard.test.tsx \
  frontend/src/components/WorkspaceHome.tsx \
  frontend/tests/e2e/dashboard-branding.spec.ts

echo
echo '== Inherited recovery helper and request usage: repaired parent =='
git show "$repaired:frontend/src/components/WorkspaceHome.tsx" |
  nl -ba |
  sed -n '180,330p'

echo
echo '== Inherited recovery helper and request usage: exact head =='
git show "$head:frontend/src/components/WorkspaceHome.tsx" |
  nl -ba |
  sed -n '180,330p'

echo
echo '== Recovery-related source difference: repaired parent -> exact head =='
git diff --unified=12 "$repaired" "$head" -- frontend/src/components/WorkspaceHome.tsx |
  grep -E -C 12 'createDashboardReadSignal|AbortSignal|signal|dashboard' || true

echo
echo '== Recovery-focused test references at exact head =='
git grep -n -E 'createDashboardReadSignal|AbortSignal|abort|timeout|fallback|recovery' "$head" -- \
  frontend/src/components/WorkspaceHome.dashboard.test.tsx \
  frontend/src/components/WorkspaceHome.tsx \
  docs/doctoring/dashboard_customer_copy.md || true

echo
echo '== Repaired parent delta from its direct parent =='
git diff --name-status "$parent_base" "$repaired"
git diff --unified=20 "$parent_base" "$repaired" -- AGENTS.md

echo
echo '== AGENTS merge-resolution deletion and exact-head content status =='
git diff --unified=20 "$first" "$head" -- AGENTS.md
if git cat-file -e "$head:AGENTS.md" 2>/dev/null; then
  echo 'AGENTS.md exists at exact head'
  git show "$head:AGENTS.md" | nl -ba | sed -n '1,160p'
else
  echo 'AGENTS.md does not exist at exact head'
fi

Length of output: 29780


🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='f6648f8e63d1e00cc08502c0f60b5f1d64ad0252'
repaired='aeeda1ea66b4c181bb01050b4bb469955ce00d0c'

echo '== Recovery source change locations relative to repaired parent =='
git diff --unified=8 "$repaired" "$head" -- frontend/src/components/WorkspaceHome.tsx

echo
echo '== Exact-head recovery helper and its API call sites =='
git show "$head:frontend/src/components/WorkspaceHome.tsx" |
  awk '
    /function createDashboardReadSignal\(/ { show=1 }
    show { printf "%d:%s\n", NR, $0 }
    show && /^}/ { helperEnd=NR; show=0 }
    /createDashboardReadSignal\(/ && NR != helperEnd { printf "%d:%s\n", NR, $0 }
  '

echo
echo '== Equality checks for inherited recovery implementation =='
for pattern in \
  'function createDashboardReadSignal' \
  'const signal = createDashboardReadSignal' \
  'retryDashboardData' \
  '업무 현황을 모두 불러오지 못했습니다.'; do
  echo "-- $pattern --"
  git show "$repaired:frontend/src/components/WorkspaceHome.tsx" | grep -F "$pattern" || true
  git show "$head:frontend/src/components/WorkspaceHome.tsx" | grep -F "$pattern" || true
done

echo
echo '== Exact-head E2E recovery and comparison test blocks =='
git show "$head:frontend/tests/e2e/dashboard-branding.spec.ts" |
  awk '
    /for \(const comparisonState of/ { show=1 }
    /test\(`recovers the Today dashboard/ { show=1 }
    show { printf "%d:%s\n", NR, $0 }
    show && /^}$/ { closeCount++; if (closeCount >= 2) { show=0; closeCount=0 } }
  ' |
  sed -n '1,300p'

echo
echo '== Exact child path set relative to repaired parent =='
actual="$(git diff --name-only "$repaired" "$head" | sort)"
expected="$(printf '%s\n' \
  docs/doctoring/dashboard_customer_copy.md \
  frontend/src/components/WorkspaceHome.dashboard.test.tsx \
  frontend/src/components/WorkspaceHome.tsx \
  frontend/tests/e2e/dashboard-branding.spec.ts | sort)"
printf '%s\n' "$actual"
if [ "$actual" = "$expected" ]; then
  echo 'path-set-match=yes'
else
  echo 'path-set-match=no'
fi

echo
echo '== Any AGENTS path in full repaired-parent ancestry comparison =='
git diff --name-status "$repaired" "$head" -- . ':(exclude)AGENTS.md' >/dev/null
if git diff --quiet "$repaired" "$head" -- AGENTS.md ':**/AGENTS.md'; then
  echo 'AGENTS-delta=no'
else
  echo 'AGENTS-delta=yes'
fi

Length of output: 13135


@seonghobae Review complete for exact head f6648f8e63d1e00cc08502c0f60b5f1d64ad0252.

I found no valid review findings.

  • The repaired parent aeeda1ea66b4c181bb01050b4bb469955ce00d0c is an ancestor of this head.
  • The delta relative to that parent contains exactly these four files:
    • docs/doctoring/dashboard_customer_copy.md
    • frontend/src/components/WorkspaceHome.dashboard.test.tsx
    • frontend/src/components/WorkspaceHome.tsx
    • frontend/tests/e2e/dashboard-branding.spec.ts
  • No AGENTS delta remains relative to the repaired parent.
  • The merge resolution deletes the prior AGENTS.md governance write from the first-parent side.
  • The inherited createDashboardReadSignal recovery helper, request use, retry flow, and recovery behavior remain unchanged.
  • The copy tests cover both ETag states. The E2E tests retain recovery checks and page-error assertions.

I did not use predecessor review state. I did not run repository tests in this read-only environment.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Preserve the four-file customer-facing copy delta while ordinary-adopting #15709ff6a2a and its canonical #1623 frontend security ancestry. No child product delta or security-owner file is dropped.
seonghobae added a commit that referenced this pull request Sep 9, 2026
Preserve the two-file skip-link accessibility delta while ordinary-adopting #15784987aad and the canonical #1623 frontend security ancestry. No force update or child delta loss.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

Please review exact head 4987aad475b3cf3a50b1512e5515695f8ac16cfe after the ordinary restack onto #1570@9ff6a2a1.... The effective child delta remains exactly four customer-copy files; predecessor review evidence must not be transferred.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

head='4987aad475b3cf3a50b1512e5515695f8ac16cfe'
expected_parent='9ff6a2a1ec64b23e5d2c6c4afe1c00334a84df30'

echo '== Requested commit =='
git rev-parse HEAD
git rev-parse "$head"
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$head"

echo
echo '== Parent commits =='
for parent in $(git show -s --format=%P "$head"); do
  git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$parent"
done

echo
echo '== Expected prerequisite relationship =='
if git merge-base --is-ancestor "$expected_parent" "$head"; then
  echo 'expected-parent-is-ancestor=yes'
else
  echo 'expected-parent-is-ancestor=no'
fi

parents=($(git show -s --format=%P "$head"))
first_parent="${parents[0]}"
second_parent="${parents[1]:-}"

echo
echo '== Child delta relative to stated prerequisite =='
git diff --name-status "$expected_parent" "$head"
echo '-- stat --'
git diff --stat "$expected_parent" "$head"

echo
echo '== Verify four-file child path set =='
actual="$(git diff --name-only "$expected_parent" "$head" | LC_ALL=C sort)"
expected="$(printf '%s\n' \
  docs/doctoring/dashboard_customer_copy.md \
  frontend/src/components/WorkspaceHome.dashboard.test.tsx \
  frontend/src/components/WorkspaceHome.tsx \
  frontend/tests/e2e/dashboard-branding.spec.ts | LC_ALL=C sort)"
printf '%s\n' "$actual"
if [ "$actual" = "$expected" ]; then
  echo 'path-set-match=yes'
else
  echo 'path-set-match=no'
fi

echo
echo '== AGENTS changes relative to stated prerequisite =='
git diff --name-status "$expected_parent" "$head" -- ':(glob)**/AGENTS*' ':AGENTS*' || true

echo
echo '== Four-file diff relative to stated prerequisite =='
git diff --find-renames --unified=35 "$expected_parent" "$head" -- \
  docs/doctoring/dashboard_customer_copy.md \
  frontend/src/components/WorkspaceHome.dashboard.test.tsx \
  frontend/src/components/WorkspaceHome.tsx \
  frontend/tests/e2e/dashboard-branding.spec.ts

echo
echo '== Recovery implementation equivalence check =='
git diff --unified=12 "$expected_parent" "$head" -- frontend/src/components/WorkspaceHome.tsx \
  | grep -E -C 12 'createDashboardReadSignal|AbortSignal|retryDashboardData|signal|timeout|fallback|recovery' \
  || echo 'no-recovery-related-source-diff'

echo
echo '== Candidate-file outlines =='
for f in \
  frontend/src/components/WorkspaceHome.tsx \
  frontend/src/components/WorkspaceHome.dashboard.test.tsx \
  frontend/tests/e2e/dashboard-branding.spec.ts; do
  if [ -f "$f" ]; then
    echo "-- $f --"
    ast-grep outline "$f" --items all || true
  fi
done

Length of output: 34255


@seonghobae Review complete for exact head 4987aad475b3cf3a50b1512e5515695f8ac16cfe.

I found no valid review findings.

  • Parent 9ff6a2a1ec64b23e5d2c6c4afe1c00334a84df30 is an ancestor of this head.
  • The child delta contains exactly four files:
    • docs/doctoring/dashboard_customer_copy.md
    • frontend/src/components/WorkspaceHome.dashboard.test.tsx
    • frontend/src/components/WorkspaceHome.tsx
    • frontend/tests/e2e/dashboard-branding.spec.ts
  • No AGENTS delta exists relative to 9ff6a2a1ec64b23e5d2c6c4afe1c00334a84df30.
  • The inherited dashboard recovery implementation has no related source change.
  • The unit test covers ETag-present and ETag-absent status copy.
  • The E2E tests cover both comparison states, internal-term absence, screenshots, and page-error assertions.

I reviewed the requested exact-head delta. I did not transfer predecessor review evidence. I did not run tests in this read-only environment.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

seonghobae added a commit that referenced this pull request Sep 9, 2026
Preserve the existing two-file constrained-navigation repair while ordinary-adopting current #1601996e563 and its #1578/#1570 project-folder contract ancestry. No force update or UI delta loss.
Preserve the four-file customer-copy delta as first-parent history while adopting #1570's current security ancestry and restored CHANGELOG ownership.

Signed-off-by: Seongho Bae <me@seonghobae.me>
seonghobae added a commit that referenced this pull request Sep 9, 2026
Preserve the skip-link two-file delta as first-parent history while adopting #1578's current parent chain, including the frontend security regression repair and restored release-note ownership.

Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve #1578's four-file customer-copy delta while adopting #1570eadb882 as the current parent.

Signed-off-by: Seongho Bae <me@seonghobae.me>
seonghobae added a commit that referenced this pull request Sep 10, 2026
Preserve #1601's two-file localized skip-link delta while adopting #15781933963 as the current parent.

Signed-off-by: Seongho Bae <me@seonghobae.me>

Copy link
Copy Markdown
Contributor Author

@codex review

Review only exact head 1933963d1ed0a5f2d36e8be4238aa73a52982cb3 against current base eadb882ffc8404f599f39068b74f90c6af38c80e. The owned delta is four files: customer-facing task/calendar status copy, its doctoring, component regression and dashboard E2E coverage. Verify wording remains source-backed and that the restack did not reintroduce ancestor-owned security or release-note changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: medium Normal-priority or P2 work status: draft Draft pull request type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant