fix(home): use customer-facing task and calendar status copy - #1578
fix(home): use customer-facing task and calendar status copy#1578seonghobae wants to merge 12 commits into
Conversation
Replace implementation-facing captions without changing source fields, comparison semantics, or response guards. Preserve comparison-present and comparison-missing cases. Co-Authored-By: Codex <noreply@openai.com> Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Capture present and absent comparison baselines only after the exact label enters the viewport. Runtime source is unchanged from ae5f39d. Co-Authored-By: Codex <noreply@openai.com> Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Independent Visual Inspection completed for test-only head8b336829ca2bbf978103d1032836bbff7e01174b. Both implementation and coordinating agents directly opened all six newly generated present/absent comparison screenshots across desktop/tablet/mobile. Each target label and adjacent action is visible without observed clipping or overlap in inspected regions. Main also read the29-line E2E-only delta. The production runtime/build inputs are unchanged from ae5f39d; its existing build was reused, not represented as a newly run full build. Targeted tests6/6 in6.0s with pageerror assertions; original full484+sevenactwarnings belongs to ae5. Parent#1570 remains unmerged. No claim of all locales, real provider/authentication, translation-ledger delivery, or protected merge. Exact screenshot folders and capture procedure are in the updated PR body. |
|
Fresh cross-PR visual evidence: #1599 mocked full-product smoke at app source877f0d5c produced desktop/mobile Home screenshots, and direct inspection found the |
…ilable-state' into codex/dashboard-user-facing-copy
|
@coderabbitai review Please review exact head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
head='f6648f8e63d1e00cc08502c0f60b5f1d64ad0252'
echo '== Checked-out and requested commits =='
git rev-parse HEAD
git rev-parse "$head"
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$head"
echo
echo '== Parent commit details =='
for parent in $(git show -s --format=%P "$head"); do
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$parent"
echo
done
parents=($(git show -s --format=%P "$head"))
first_parent="${parents[0]}"
second_parent="${parents[1]}"
echo '== Child-only delta: first parent -> exact head =='
git diff --name-status "$first_parent" "$head"
echo '-- stat --'
git diff --stat "$first_parent" "$head"
echo
echo '== Adopted-parent comparison: second parent -> exact head =='
git diff --name-status "$second_parent" "$head"
echo '-- stat --'
git diff --stat "$second_parent" "$head"
echo
echo '== Merge relationship =='
printf 'merge-base(first, second)='
git merge-base "$first_parent" "$second_parent"
printf 'merge-base(head, second)='
git merge-base "$head" "$second_parent"
git merge-base --is-ancestor "$second_parent" "$head" && echo 'second-parent-is-ancestor-of-head=yes'
echo
echo '== AGENTS paths differing from repaired parent =='
agents_diff="$(git diff --name-status "$second_parent" "$head" -- ':**/AGENTS*' ':AGENTS*')"
if [ -n "$agents_diff" ]; then
printf '%s\n' "$agents_diff"
else
echo 'none'
fi
echo
echo '== Candidate files in the first-parent delta =='
git diff --name-only "$first_parent" "$head"
echo
echo '== Source/test structure =='
for name in WorkspaceHome.tsx WorkspaceHome.dashboard.test.tsx dashboard-branding.spec.ts dashboard_customer_copy.md; do
fd -a -t f -e tsx -e ts -e md -g "$name" . || true
done
echo
echo '== Outline source and test files =='
for f in $(fd -a -t f -g 'WorkspaceHome.tsx' -g 'WorkspaceHome.dashboard.test.tsx' -g 'dashboard-branding.spec.ts' .); do
echo "-- $f --"
ast-grep outline "$f" --items all || true
doneLength of output: 7660 🏁 Script executed: #!/bin/bash
set -euo pipefail
head='f6648f8e63d1e00cc08502c0f60b5f1d64ad0252'
first='34fc2c8399c233206c9aa73f3ac1668c50dc1a29'
repaired='aeeda1ea66b4c181bb01050b4bb469955ce00d0c'
parent_base='187f33255af4a73fce7a2508580c51cd75837f4c'
echo '== Four-file delta relative to repaired parent =='
git diff --find-renames --unified=40 "$repaired" "$head" -- \
docs/doctoring/dashboard_customer_copy.md \
frontend/src/components/WorkspaceHome.dashboard.test.tsx \
frontend/src/components/WorkspaceHome.tsx \
frontend/tests/e2e/dashboard-branding.spec.ts
echo
echo '== Inherited recovery helper and request usage: repaired parent =='
git show "$repaired:frontend/src/components/WorkspaceHome.tsx" |
nl -ba |
sed -n '180,330p'
echo
echo '== Inherited recovery helper and request usage: exact head =='
git show "$head:frontend/src/components/WorkspaceHome.tsx" |
nl -ba |
sed -n '180,330p'
echo
echo '== Recovery-related source difference: repaired parent -> exact head =='
git diff --unified=12 "$repaired" "$head" -- frontend/src/components/WorkspaceHome.tsx |
grep -E -C 12 'createDashboardReadSignal|AbortSignal|signal|dashboard' || true
echo
echo '== Recovery-focused test references at exact head =='
git grep -n -E 'createDashboardReadSignal|AbortSignal|abort|timeout|fallback|recovery' "$head" -- \
frontend/src/components/WorkspaceHome.dashboard.test.tsx \
frontend/src/components/WorkspaceHome.tsx \
docs/doctoring/dashboard_customer_copy.md || true
echo
echo '== Repaired parent delta from its direct parent =='
git diff --name-status "$parent_base" "$repaired"
git diff --unified=20 "$parent_base" "$repaired" -- AGENTS.md
echo
echo '== AGENTS merge-resolution deletion and exact-head content status =='
git diff --unified=20 "$first" "$head" -- AGENTS.md
if git cat-file -e "$head:AGENTS.md" 2>/dev/null; then
echo 'AGENTS.md exists at exact head'
git show "$head:AGENTS.md" | nl -ba | sed -n '1,160p'
else
echo 'AGENTS.md does not exist at exact head'
fiLength of output: 29780 🏁 Script executed: #!/bin/bash
set -euo pipefail
head='f6648f8e63d1e00cc08502c0f60b5f1d64ad0252'
repaired='aeeda1ea66b4c181bb01050b4bb469955ce00d0c'
echo '== Recovery source change locations relative to repaired parent =='
git diff --unified=8 "$repaired" "$head" -- frontend/src/components/WorkspaceHome.tsx
echo
echo '== Exact-head recovery helper and its API call sites =='
git show "$head:frontend/src/components/WorkspaceHome.tsx" |
awk '
/function createDashboardReadSignal\(/ { show=1 }
show { printf "%d:%s\n", NR, $0 }
show && /^}/ { helperEnd=NR; show=0 }
/createDashboardReadSignal\(/ && NR != helperEnd { printf "%d:%s\n", NR, $0 }
'
echo
echo '== Equality checks for inherited recovery implementation =='
for pattern in \
'function createDashboardReadSignal' \
'const signal = createDashboardReadSignal' \
'retryDashboardData' \
'업무 현황을 모두 불러오지 못했습니다.'; do
echo "-- $pattern --"
git show "$repaired:frontend/src/components/WorkspaceHome.tsx" | grep -F "$pattern" || true
git show "$head:frontend/src/components/WorkspaceHome.tsx" | grep -F "$pattern" || true
done
echo
echo '== Exact-head E2E recovery and comparison test blocks =='
git show "$head:frontend/tests/e2e/dashboard-branding.spec.ts" |
awk '
/for \(const comparisonState of/ { show=1 }
/test\(`recovers the Today dashboard/ { show=1 }
show { printf "%d:%s\n", NR, $0 }
show && /^}$/ { closeCount++; if (closeCount >= 2) { show=0; closeCount=0 } }
' |
sed -n '1,300p'
echo
echo '== Exact child path set relative to repaired parent =='
actual="$(git diff --name-only "$repaired" "$head" | sort)"
expected="$(printf '%s\n' \
docs/doctoring/dashboard_customer_copy.md \
frontend/src/components/WorkspaceHome.dashboard.test.tsx \
frontend/src/components/WorkspaceHome.tsx \
frontend/tests/e2e/dashboard-branding.spec.ts | sort)"
printf '%s\n' "$actual"
if [ "$actual" = "$expected" ]; then
echo 'path-set-match=yes'
else
echo 'path-set-match=no'
fi
echo
echo '== Any AGENTS path in full repaired-parent ancestry comparison =='
git diff --name-status "$repaired" "$head" -- . ':(exclude)AGENTS.md' >/dev/null
if git diff --quiet "$repaired" "$head" -- AGENTS.md ':**/AGENTS.md'; then
echo 'AGENTS-delta=no'
else
echo 'AGENTS-delta=yes'
fiLength of output: 13135
I found no valid review findings.
I did not use predecessor review state. I did not run repository tests in this read-only environment.
|
|
@coderabbitai review Please review exact head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
head='4987aad475b3cf3a50b1512e5515695f8ac16cfe'
expected_parent='9ff6a2a1ec64b23e5d2c6c4afe1c00334a84df30'
echo '== Requested commit =='
git rev-parse HEAD
git rev-parse "$head"
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$head"
echo
echo '== Parent commits =='
for parent in $(git show -s --format=%P "$head"); do
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$parent"
done
echo
echo '== Expected prerequisite relationship =='
if git merge-base --is-ancestor "$expected_parent" "$head"; then
echo 'expected-parent-is-ancestor=yes'
else
echo 'expected-parent-is-ancestor=no'
fi
parents=($(git show -s --format=%P "$head"))
first_parent="${parents[0]}"
second_parent="${parents[1]:-}"
echo
echo '== Child delta relative to stated prerequisite =='
git diff --name-status "$expected_parent" "$head"
echo '-- stat --'
git diff --stat "$expected_parent" "$head"
echo
echo '== Verify four-file child path set =='
actual="$(git diff --name-only "$expected_parent" "$head" | LC_ALL=C sort)"
expected="$(printf '%s\n' \
docs/doctoring/dashboard_customer_copy.md \
frontend/src/components/WorkspaceHome.dashboard.test.tsx \
frontend/src/components/WorkspaceHome.tsx \
frontend/tests/e2e/dashboard-branding.spec.ts | LC_ALL=C sort)"
printf '%s\n' "$actual"
if [ "$actual" = "$expected" ]; then
echo 'path-set-match=yes'
else
echo 'path-set-match=no'
fi
echo
echo '== AGENTS changes relative to stated prerequisite =='
git diff --name-status "$expected_parent" "$head" -- ':(glob)**/AGENTS*' ':AGENTS*' || true
echo
echo '== Four-file diff relative to stated prerequisite =='
git diff --find-renames --unified=35 "$expected_parent" "$head" -- \
docs/doctoring/dashboard_customer_copy.md \
frontend/src/components/WorkspaceHome.dashboard.test.tsx \
frontend/src/components/WorkspaceHome.tsx \
frontend/tests/e2e/dashboard-branding.spec.ts
echo
echo '== Recovery implementation equivalence check =='
git diff --unified=12 "$expected_parent" "$head" -- frontend/src/components/WorkspaceHome.tsx \
| grep -E -C 12 'createDashboardReadSignal|AbortSignal|retryDashboardData|signal|timeout|fallback|recovery' \
|| echo 'no-recovery-related-source-diff'
echo
echo '== Candidate-file outlines =='
for f in \
frontend/src/components/WorkspaceHome.tsx \
frontend/src/components/WorkspaceHome.dashboard.test.tsx \
frontend/tests/e2e/dashboard-branding.spec.ts; do
if [ -f "$f" ]; then
echo "-- $f --"
ast-grep outline "$f" --items all || true
fi
doneLength of output: 34255
I found no valid review findings.
I reviewed the requested exact-head delta. I did not transfer predecessor review evidence. I did not run tests in this read-only environment.
|
Preserve the four-file customer-copy delta as first-parent history while adopting #1570's current security ancestry and restored CHANGELOG ownership. Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve the skip-link two-file delta as first-parent history while adopting #1578's current parent chain, including the frontend security regression repair and restored release-note ownership. Signed-off-by: Seongho Bae <me@seonghobae.me>
|
@codex review Review only exact head |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Current authority — 2026-09-10
#1570@eadb882ffc8404f599f39068b74f90c6af38c80e1933963d1ed0a5f2d36e8be4238aa73a52982cb3behind_by=0).Current head preserves predecessor #1578 as first parent and adopts repaired #1570 as second parent through non-force ordinary ancestry. The product delta remains the customer-facing task/calendar status copy plus its doctoring, component regression and dashboard E2E coverage; inherited security and release-note ownership remain with ancestors.
Pre-restack checks/reviews are predecessor evidence only. This exact head currently has no PR-triggered hosted workflow run.
UI Delivery Gate: FAIL
Intentionality/content scope are PASS. Current-head hosted execution, rendered responsive/keyboard evidence, applicable locale expansion checks and a qualifying post-restack independent review remain incomplete.