fix(a11y): localize the workspace skip link - #1601
Conversation
Match the Korean document locale and reveal the focused link as a full-width header strip so it remains readable at desktop and mobile widths. Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visual Inspection receipt for exact head
The initial compact pill overlapped the Naruon logo at 390px; the final strip is the visual-inspection-driven repair. This PR remains Draft while stacked parent #1578 is Proposed. |
…r-facing-copy' into codex/localize-skip-link
|
Non-force restack receipt: merged parent #1578 head |
|
@coderabbitai review Please review exact head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
requested_head='9b50391133c94f9472b84dabd3f84714e5492c3d'
expected_parent_prefix='f6648f8e'
echo '== Checked-out commit =='
git rev-parse HEAD
git status --short
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$requested_head"
echo
echo '== Locate the full expected parent commit =='
git rev-parse "${expected_parent_prefix}^{commit}" || true
echo
echo '== Parent graph and merge-base =='
git show -s --format='%P' "$requested_head"
git merge-base "$requested_head" "${expected_parent_prefix}^{commit}"
echo
echo '== Files changed from `#1578` parent to requested head =='
git diff --name-status "${expected_parent_prefix}^{commit}" "$requested_head"
git diff --stat "${expected_parent_prefix}^{commit}" "$requested_head"
echo
echo '== Exact product diff =='
git diff --find-renames --find-copies --unified=80 \
"${expected_parent_prefix}^{commit}" "$requested_head" -- \
frontend/src/components/DashboardLayout.tsx \
frontend/src/components/DashboardLayout.test.tsx
echo
echo '== Component and test outlines =='
ast-grep outline frontend/src/components/DashboardLayout.tsx --items all --view expanded
ast-grep outline frontend/src/components/DashboardLayout.test.tsx --items all --view expanded
echo
echo '== Skip-link-related source and test context =='
rg -n -C 12 --glob 'DashboardLayout.tsx' --glob 'DashboardLayout.test.tsx' \
'본문 바로가기|Skip to main content|skip|focus:|tabIndex|<main|id=' \
frontend/src/components
echo
echo '== Existing DashboardLayout test commands =='
rg -n -C 4 --glob 'package.json' --glob 'vitest.config.*' --glob 'vite.config.*' \
'DashboardLayout|test|vitest' .Length of output: 51175
I found no blocking issue.
I did not execute tests or browser checks in this sandbox. This review does not transfer predecessor verification state. Current-head hosted checks and required independent review remain necessary before merge.
|
|
@coderabbitai review Please review exact head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
head='251502101b15c328f53882d9b8e73fd3c3b7ba50'
base='4987aad475b3cf3a50b1512e5515695f8ac16cfe'
echo '== Exact commit and repository state =='
git rev-parse HEAD
git status --short
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$head"
git rev-parse "${base}^{commit}"
echo
echo '== Parent and merge-base validation =='
git merge-base "$head" "$base"
git merge-base --is-ancestor "$base" "$head" && echo 'base-is-ancestor=yes'
echo
echo '== Effective delta paths =='
git diff --name-status "$base" "$head"
git diff --stat "$base" "$head"
echo
echo '== Effective delta =='
git diff --find-renames --find-copies --unified=80 "$base" "$head" -- \
frontend/src/components/DashboardLayout.tsx \
frontend/src/components/DashboardLayout.test.tsx
echo
echo '== Component and test structure =='
ast-grep outline frontend/src/components/DashboardLayout.tsx --items all --view expanded
ast-grep outline frontend/src/components/DashboardLayout.test.tsx --items all --view expanded
echo
echo '== Skip-link and main-target context =='
rg -n -C 16 --glob 'DashboardLayout.tsx' --glob 'DashboardLayout.test.tsx' \
'본문 바로가기|Skip to main content|href=|<main|main-content|focus:|sr-only|tabIndex' \
frontend/src/components
echo
echo '== Related layout implementation context =='
sed -n '1,260p' frontend/src/components/DashboardLayout.tsx
sed -n '1,320p' frontend/src/components/DashboardLayout.test.tsxLength of output: 99158
I found no blocking issue in the effective child delta.
I did not run repository tests or browser checks in this sandbox. This review does not transfer predecessor approval or verification state. Current-head hosted checks, independent review, and visual evidence remain required before merge.
|
Preserve the skip-link two-file delta as first-parent history while adopting #1578's current parent chain, including the frontend security regression repair and restored release-note ownership. Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve the constrained-navigation two-file delta as first-parent history while adopting #1601's current parent chain, including the security regression repair and restored release-note ownership. Signed-off-by: Seongho Bae <me@seonghobae.me>
|
@codex review Review only exact head |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Current authority — 2026-09-10
#1578@1933963d1ed0a5f2d36e8be4238aa73a52982cb3f9cbc828ce481f259c940d809ddb7fc573ea66d5behind_by=0).Current head preserves predecessor #1601 as first parent and adopts current #1578 as second parent through a non-force ordinary restack. The product delta remains the localized workspace skip link and its regression test; inherited security, Today recovery and customer-copy source remain owned by ancestors.
Pre-restack checks/reviews are not current-head authorization. This exact head currently has no PR-triggered hosted workflow run.
UI Delivery Gate: FAIL
The skip-link change remains bounded and intentional. Current-head hosted execution, rendered focus/keyboard evidence, applicable locale expansion checks and a qualifying post-restack independent review are still required.