fix(network-graph): preserve keyboard tooltip access - #1561
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seonghobae
added a commit
that referenced
this pull request
Sep 4, 2026
seonghobae
marked this pull request as draft
September 4, 2026 13:47
Keep the unavailable-action explanation under the pointer, let Escape dismiss the focused overlay without moving focus, and cover both interactions in unit and browser tests. Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
seonghobae
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Stable complete successor for #1500. The predecessor accumulated repeated empty
Trigger CIcommits that changed exact-head identity without product delta. This PR carries the complete validated accessibility tree directly on protecteddevelop, while #1500 remains open for lineage and equivalence verification.Exact authority
develop@042b0c70531b229af3acbd0421a2f23098d848b3dea8edb64d4ae492aec8815798edad8b4200c1dd9014b174aa1a07a2b6fee60c7211e1f3e9b09b4cAuthor-side evidence retained for this tree: NetworkGraph unit suite 13 passed, real-keyboard Playwright regression 1 passed using Shift+Tab, TypeScript passed, and
git diff --checkpassed. No predecessor check or approval transfers.Fresh review evidence is not merge-authoritative: CodeRabbit could not review this exact head because the current review quota is exhausted. That transient reviewer-capacity condition is not a Naruon source defect and does not justify a no-op commit, fabricated review, protection bypass, or gate weakening.
Keep Draft until this unchanged head has every then-live required hosted check terminal-success, all valid findings/threads resolved, and the effective live governance satisfied. Close #1500 only after #1561 merges and complete tree/delta equivalence is reverified. No force push, destructive rebase, self-approval, admin bypass, dummy requeue commit, or predecessor evidence transfer.
Complete predecessor-finding inheritance
Exact head dea8edb also inherits the two current #1500 accessibility findings: the tooltip is hit-testable with no pointer gap, and Escape dismisses the focus overlay without moving focus. Focus or pointer re-entry restores the explanation. Fresh evidence: 13 unit tests, TypeScript, ESLint, diff check, and one isolated real-browser desktop regression pass. The first browser attempt reused an unrelated server on the default port and returned a 404; the authoritative rerun used isolated port 18161 with CI server isolation and passed without warning output.