chore(a11y): preserve conflicting generated accessibility lineage - #1579
chore(a11y): preserve conflicting generated accessibility lineage#1579seonghobae wants to merge 3 commits into
Conversation
…a-disabled` 속성 기반으로 마이그레이션하여 스크린 리더와 키보드 접근성을 향상시켰습니다. - 조건부 비활성화 버튼에 툴팁 정보가 키보드 포커스와 스크린 리더에 정상적으로 읽히도록 마이그레이션했습니다. - 폼 전송 버튼(`type="submit"`)에서 기본 동작 이벤트를 `e.preventDefault()`로 제어하여 예상치 못한 동작을 방지했습니다.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… 발생하는 의존성 오류를 해결했습니다. - 스크린 리더와 키보드 접근성을 향상시키기 위해 `SearchLayout`과 `NetworkGraph` 컴포넌트의 `disabled` 속성 버튼들을 `aria-disabled` 속성으로 변경했습니다. - 조건부 비활성화 버튼들의 툴팁 정보가 올바르게 작동하도록 구현했습니다.
Lifecycle repair
This generated direct-
developPR is preserved as provenance but is no longer an active Naruon source writer.develop@042b0c70531b229af3acbd0421a2f23098d848b34537f187862f1cf24a4189d50469fc1a47bf449bfffb4c0d6d7a59cacfee031a9f9e48f76e312ee8developtree8fde14381aaa430eeaaf61151dab6f6800127cd3; GitHub reports an empty PR diff.Why the generated branch is not product authority
The generated branch mixed an accessibility proposal with unrelated LLM/provider configuration and test changes across 11 files. In particular, it changed
gpt-5.4togpt-4oin backend provider tests, Settings runtime defaults/tests, full-product smoke fixtures, and E2E helpers. A UI accessibility PR does not own model/provider routing or defaults, and Naruon must consume the released contextual-orchestrator contract rather than create a provider/model migration as a side effect of button work.The accessibility delta also overlaps existing canonical Naruon lanes:
aria-disabled, descriptive tooltip/IDREF behavior, sequential keyboard reachability, Escape dismissal, and guarded activation.Native
disabledversus focusablearia-disabledis an action-specific interaction decision, not a blanket migration rule. The generated branch did not establish a unique bounded contract strong enough to become another writer for those surfaces.No generated source/test/CHANGELOG/model-config delta is current product authority. The historical commits remain in ancestry; no force-push, destructive rebase, self-approval, dummy requeue, or gate weakening was used.
Succession boundary
Do not close this PR merely to reduce the queue. Keep it open Draft until the canonical owner lanes are protected-integrated and a fresh equivalence/succession audit proves every valid accessibility source, test, fixture, interaction, and evidence contribution from the generated commits is either completely inherited or deliberately rejected with recorded rationale. Only verified complete succession may justify closure.