test(etl): reproduce invalid amount coercion on live develop - #309
Closed
seonghobae wants to merge 1 commit into
Closed
test(etl): reproduce invalid amount coercion on live develop#309seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds #198 test-first from exact protected
develop@f340d37caba9df0d4aeb88e5d18b78bd8cca4b60rather than rewriting stale/conflicting #199.This is intentionally test-only RED at exact head
6e49df6a419f8b25501e074d06fb7e3dd50381f4.EtlServiceAmountIntegrityTestreaches the realEtlService.processData(...)boundary and requires malformed, blank, excessive-precision and extreme-scaleAMOUNTinput to fail asINVALID_RECORDbefore JDBC. It also requires one invalid amount in a multi-record request to abort the entire prevalidated batch before any write.Protected production still maps these invalid inputs to valid-looking
0.00, so the expected current result is deterministic RED. After that causal proof, apply only the bounded production correction and then align current docs/CHANGELOG without overwriting unrelated protected changes. Old #199 checks/reviews/base snapshots remain historical and do not transfer.