Skip to content

test(etl): reproduce invalid amount coercion on current develop - #310

Closed
seonghobae wants to merge 4 commits into
developfrom
repro/reject-invalid-amount-4408b60
Closed

test(etl): reproduce invalid amount coercion on current develop#310
seonghobae wants to merge 4 commits into
developfrom
repro/reject-invalid-amount-4408b60

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Rebuilds issue #198 test-first from exact protected develop@4408b6086fd725ff1629d8f048cf28f3a2b40b1b because PR #309 no longer descends from the live protected tip.

This intentionally contains only the RED production-boundary test. EtlServiceAmountIntegrityTest requires malformed, blank, excessive-precision and extreme-scale AMOUNT values to fail as INVALID_RECORD before JDBC, and requires one invalid amount in a multi-record request to abort the complete prevalidated batch before any write.

Protected production at the rebuild base still converts these inputs to valid-looking 0.00; the next step is to obtain exact-head RED evidence, then apply only the narrow fail-closed production correction. Evidence from #309 or earlier #199 does not transfer to this rebuilt head.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f8a9d168-295b-473c-9a7b-326ce48b567d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Superseded by current-base replacement #316. Fresh comparison at legacy head 0757cee58f950d1f0f20305119cdf9ae9656c026 and replacement head 2d3140e9b76a4b0ad302489310b51816b673ae72 confirms #316 preserves the same seven amount-integrity production/test/docs/changelog changes and adds the stricter JSON-type boundary test for AMOUNT. The replacement descends from current protected develop@feaea5d2a353d74919afc9a6971e8c15da5dd2f3; old checks/reviews do not transfer. #316 currently has a real RED on its added JSON-type boundary (null/object/array are still accepted before AMOUNT dispatch), so this closure removes duplicate stale-base work only and does not claim the replacement is merge-ready.

Copy link
Copy Markdown
Collaborator Author

Superseded by #316. Fresh ancestry verification shows replacement commit bfbf116541ed243876392112ca78685397773ac2 has exact #310 head 0757cee58f950d1f0f20305119cdf9ae9656c026 as a parent alongside protected develop@feaea5d2a353d74919afc9a6971e8c15da5dd2f3; current #316 head descends from that replacement commit. #310 has no formal reviews or inline review findings to preserve. Prior checks do not transfer to #316.

Copy link
Copy Markdown
Collaborator Author

Superseded by #316 after non-destructive live-base reconstruction. Exact #310 head 0757cee58f950d1f0f20305119cdf9ae9656c026 is the merge base/ancestor of current #316 head 51424b3e903fce76c7c6904ea8930e04be71ddca (ahead_by=4, behind_by=0), so #310 has no unique work that is not preserved by #316. No checks or reviews are transferred; #316 must earn fresh evidence on its own exact head.

@seonghobae seonghobae closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant