test(cdc): replay replica diagnostic confidentiality on live develop - #301
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough검증 및 복제본 데이터 소스 오류 메시지에서 입력값과 원인 예외를 제거했습니다. 클래스와 Bean 메서드에 Javadoc을 추가했습니다. 입력값 비노출 동작을 검증하는 테스트를 추가했습니다. Changes진단 메시지 비노출
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@cdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.java`:
- Around line 150-159: Update the failure-message assertions in the
Throwable-cause loop to reject carriage return and newline characters
independently, rather than checking only rejectedValue. In the direct invocation
path for failure, add assertNull(failure.getCause()) while preserving the
existing key and authorization assertions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0382782b-bb0c-496f-9a92-b8da2c9be6d7
📒 Files selected for processing (4)
cdc-service/src/main/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfig.javacdc-service/src/main/java/com/xtrmetl/cdc/util/ValidationUtils.javacdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.javacdc-service/src/test/java/com/xtrmetl/cdc/util/ValidationUtilsTest.java
Rebuilds issue #210 from exact protected
develop@609b2901d9b6b7a32c38cbbce4d27ace30dbe042instead of rewriting stale/diverged PR #283. Current test-only RED head586ea27e684cec290829142ed9c15dc98a63cd9fadds a realistic credential-like/CRLF diagnostic-confidentiality contract against the realValidationUtilsproduction boundary. Protected production still republishes rejected values, so hosted RED is expected before the narrow production repair. Keep Draft through RED→GREEN and the separate Hikari-timeout RED→GREEN. No predecessor/synthetic/status-only evidence transfers; protected integration still requires exact-head CI/security/non-vacuous coverage and qualifying independent approval.Summary by CodeRabbit