Skip to content

test(cdc): replay replica diagnostic confidentiality on live develop - #301

Merged
github-actions[bot] merged 8 commits into
developfrom
fix/cdc-validation-diagnostic-confidentiality-609b290
Aug 12, 2026
Merged

test(cdc): replay replica diagnostic confidentiality on live develop#301
github-actions[bot] merged 8 commits into
developfrom
fix/cdc-validation-diagnostic-confidentiality-609b290

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Rebuilds issue #210 from exact protected develop@609b2901d9b6b7a32c38cbbce4d27ace30dbe042 instead of rewriting stale/diverged PR #283. Current test-only RED head 586ea27e684cec290829142ed9c15dc98a63cd9f adds a realistic credential-like/CRLF diagnostic-confidentiality contract against the real ValidationUtils production boundary. Protected production still republishes rejected values, so hosted RED is expected before the narrow production repair. Keep Draft through RED→GREEN and the separate Hikari-timeout RED→GREEN. No predecessor/synthetic/status-only evidence transfers; protected integration still requires exact-head CI/security/non-vacuous coverage and qualifying independent approval.

Summary by CodeRabbit

  • 개선 사항
    • 설정 및 검증 오류 메시지에서 민감한 입력값, 제어 문자, 인증 정보가 노출되지 않도록 개선했습니다.
    • 오류 진단 시 설정 항목과 검증 유형은 계속 확인할 수 있습니다.
    • 잘못되거나 과도하게 긴 설정값도 안전하게 처리됩니다.
  • 문서화
    • 설정 및 검증 동작에 대한 설명을 보강했습니다.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 24d88e04-36db-4331-8c64-b70a6982fda7

📥 Commits

Reviewing files that changed from the base of the PR and between 504a7ec and 9eef90b.

📒 Files selected for processing (1)
  • cdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • cdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.java

📝 Walkthrough

Walkthrough

검증 및 복제본 데이터 소스 오류 메시지에서 입력값과 원인 예외를 제거했습니다. 클래스와 Bean 메서드에 Javadoc을 추가했습니다. 입력값 비노출 동작을 검증하는 테스트를 추가했습니다.

Changes

진단 메시지 비노출

Layer / File(s) Summary
검증 오류 메시지 정리
cdc-service/src/main/java/com/xtrmetl/cdc/util/ValidationUtils.java, cdc-service/src/test/java/com/xtrmetl/cdc/util/ValidationUtilsTest.java
포트, 호스트, 식별자 검증 규칙은 유지합니다. 오류 메시지에서 입력값과 숫자 변환 원인 예외를 제거했습니다. 민감한 문자열과 제어 문자를 검증하는 테스트를 추가했습니다.
복제본 데이터 소스 오류 처리
cdc-service/src/main/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfig.java, cdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.java
초기화 타임아웃 파싱 실패 시 고정된 IllegalStateException 메시지를 사용합니다. 설정 키는 예외 체인에 유지하고 입력값과 인증 정보를 제외하는 테스트를 추가했습니다. 관련 Javadoc도 추가했습니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 CDC 진단 정보 기밀성 검증 테스트와 직접 관련되며, 변경 사항의 주요 목적을 명확하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cdc-validation-diagnostic-confidentiality-609b290

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 12, 2026 02:22

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@cdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.java`:
- Around line 150-159: Update the failure-message assertions in the
Throwable-cause loop to reject carriage return and newline characters
independently, rather than checking only rejectedValue. In the direct invocation
path for failure, add assertNull(failure.getCause()) while preserving the
existing key and authorization assertions.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0382782b-bb0c-496f-9a92-b8da2c9be6d7

📥 Commits

Reviewing files that changed from the base of the PR and between 609b290 and 504a7ec.

📒 Files selected for processing (4)
  • cdc-service/src/main/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfig.java
  • cdc-service/src/main/java/com/xtrmetl/cdc/util/ValidationUtils.java
  • cdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.java
  • cdc-service/src/test/java/com/xtrmetl/cdc/util/ValidationUtilsTest.java

@github-actions
github-actions Bot merged commit 502d1e2 into develop Aug 12, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant