Skip to content

feat: connect exact photo duplicates to reversible quarantine - #316

Open
seonghobae wants to merge 35 commits into
feat/podman-storage-repair-v1from
feat/photo-duplicate-quarantine-integration-v1
Open

feat: connect exact photo duplicates to reversible quarantine#316
seonghobae wants to merge 35 commits into
feat/podman-storage-repair-v1from
feat/photo-duplicate-quarantine-integration-v1

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Responsibility boundary

  • Base 7be69db1a46c3cd6cc8cd94b5c103f48336e5c7a owns the shared photo quarantine executor, active-use/materialization/identity preflight, Trash, journal, and restore receipts.
  • Merged feat: add evidence-bound photo duplicate audit #313 head 2281eb634d3e56de6b580465cc70dfccfa341826 owns read-only exact decoded-pixel grouping and Pareto keeper evidence.
  • This PR adds only the adapter and Tauri IPC boundary. It does not duplicate the executor.

Safety

  • Recollects exact evidence before plan and execution; stale or forged audits fail closed.
  • A unique Pareto keeper is preserved automatically; ties require an explicit survivor selection.
  • Near-duplicates remain outside this exact-decoded path.
  • Execution still uses the shared all-member identity, materialization, hard-link, active-use, replacement, OS Trash, journal, and receipt contract. Permanent delete remains unavailable.

Validation

  • cargo test --manifest-path src-tauri/Cargo.toml --lib photo_duplicate_quarantine (3 passed)
  • git diff --check

No live photo or provider mutation was performed.


Devin Review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f4b6454-194c-44d8-80fe-7fa1e6639e7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

…integration-v1' into feat/photo-duplicate-quarantine-integration-v1

# Conflicts:
#	src/lib/ExactPhotoReview.svelte
#	src/lib/photoReviewState.test.ts
#	src/lib/photoReviewState.ts
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 3 new potential issues.

Devin Review

Comment thread src-tauri/src/photo_duplicate_quarantine.rs
Comment thread src-tauri/src/photo_duplicate_quarantine.rs
Comment thread src-tauri/src/photo_duplicate_quarantine.rs

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 1 new potential issue.

Devin Review

Comment thread src-tauri/src/photo_duplicate_quarantine.rs

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment thread src-tauri/src/container_orphan_reclaim.rs
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant