Skip to content

feat: review Apple Photos duplicates through PhotoKit - #317

Open
seonghobae wants to merge 14 commits into
feat/photo-duplicate-quarantine-integration-v1from
feat/apple-photos-duplicate-library-v1
Open

feat: review Apple Photos duplicates through PhotoKit#317
seonghobae wants to merge 14 commits into
feat/photo-duplicate-quarantine-integration-v1from
feat/apple-photos-duplicate-library-v1

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Outcome

  • inventories Apple Photos through PhotoKit without traversing managed library packages
  • disables network access for resource evidence, preserving iCloud-only originals without downloading them
  • groups only exact SHA-256 matches and keeps measured quality dimensions separate
  • requires an explicit keeper, fresh plan-bound phrase, rationale, full participant re-fetch/re-hash, Photos system confirmation, and a create-new receipt
  • fails closed outside macOS and exposes the next customer action

Verification

  • cargo test -p disksage photos_library --lib (5 passed)
  • npm test -- --run src/lib/photosLibraryState.test.ts (1 passed)
  • npm run build
  • macOS browser screenshot inspected at 1440x5200; 44px controls, focus styling, next-action copy, and responsive layout are present
  • no live Photos mutation was performed

Research

Stacked on #316.


Devin Review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d28232cd-4c3c-4854-bbca-35a802abb552

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

# Conflicts:
#	src/lib/cacheCleanupAtomicTrashContract.test.ts
#	src/lib/cacheCleanupFlowContract.test.ts
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant