fix: support standard Intel Homebrew executable target - #205
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The Intel Homebrew executable slice is ready for review at exact head |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head5c86668a6e503a174ff0b07151f67226b39547ff. -
Head SHA:
5c86668a6e503a174ff0b07151f67226b39547ff -
Workflow run: 32702639442
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
…ate-authority-v1' into pr-205
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
src-tauri/src/brew_cleanup.rs— Rust package behaviorsrc-tauri/tests/brew_cleanup_intel_install_contract.rs— regression suite
Changed behavior
classDiagram
class BrewCleanupPlan
class approval_phrase
class BrewCleanupJudgment
class has_successful_calibration
class BrewCleanupExecution
class BrewCleanupAuditRecord
class plan
class prompt
Changed API
BrewCleanupPlanapproval_phraseBrewCleanupJudgmenthas_successful_calibrationBrewCleanupExecutionBrewCleanupAuditRecordplanpromptjudgeexecutewrite_audit_recordwrite_audit_record_with_before_create_hook
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
1052a75a8faff51a242bb0999f0a06b0d2b763a6 - Workflow run: 33363203625
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
classDiagram
class BrewCleanupPlan
class approval_phrase
class BrewCleanupJudgment
class has_successful_calibration
class BrewCleanupExecution
class BrewCleanupAuditRecord
class plan
class prompt
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
src-tauri/src/brew_cleanup.rs— Rust package behaviorsrc-tauri/tests/brew_cleanup_intel_install_contract.rs— regression suite
Changed behavior
classDiagram
class BrewCleanupPlan
class approval_phrase
class BrewCleanupJudgment
class has_successful_calibration
class BrewCleanupExecution
class BrewCleanupAuditRecord
class plan
class prompt
Changed API
BrewCleanupPlanapproval_phraseBrewCleanupJudgmenthas_successful_calibrationBrewCleanupExecutionBrewCleanupAuditRecordplanpromptjudgeexecutewrite_audit_recordwrite_audit_record_with_before_create_hook
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
1052a75a8faff51a242bb0999f0a06b0d2b763a6 - Workflow run: 33580608419
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
classDiagram
class BrewCleanupPlan
class approval_phrase
class BrewCleanupJudgment
class has_successful_calibration
class BrewCleanupExecution
class BrewCleanupAuditRecord
class plan
class prompt
|
Exact-head cancellation RCA and successor verification (2026-09-07). Current authority remains Test run Because the cancellation left required exact-head evidence incomplete, I reran failed jobs once. The same run's successor attempt produced:
This establishes repository-owned Test GREEN on the unchanged head without a dummy commit or cancellation suppression. It does not convert Draft Release |
Purpose
Make the local-LLM-gated Homebrew cleanup available on a standard Intel macOS Homebrew installation without following or trusting the public
/usr/local/bin/brewalias symlink and without changing command, dry-run, model, human-approval, executable-identity, audit, or filesystem authority.Root cause
The official Homebrew installer uses
/usr/localas the Intel prefix, stores the repository at/usr/local/Homebrew, and creates/usr/local/bin/brewas../Homebrew/bin/brew. DiskSage rejected that public symlink alias while omitting the actual fixed repository target, so a standard Intel installation failed asbrew-cleanup-brew-not-foundbefore object-bound executable verification.The predecessor exact head
1052a75a8faff51a242bb0999f0a06b0d2b763a6also inherited the release artifact namespace failure from its parent: Release run33261220173, job99126807927downloaded the Windows artifact underrelease-disksage-windows-2022-1, while the verifier expectedrelease-disksage-windows-latest-1. The canonical release-owner correction is #264; this PR does not duplicate or weaken it.Exact current state — 2026-09-07
fa1fead83d77d01a1ec00dddcb6c0fd317e145e0b01fb34124f573a0c7b31f8e1a239558c16573e7b01fb34124f573a0c7b31f8e1a239558c16573e7ahead 8 / behind 0, merge basefa1fead83d77d01a1ec00dddcb6c0fd317e145e0src-tauri/src/brew_cleanup.rsandsrc-tauri/tests/brew_cleanup_intel_install_contract.rsnpm testpassed 40 Vitest files / 164 tests plus 2 Node concurrency tests;git diff --cached --checkpassed before commit constructioncargo; hosted exact-head Rust evidence remains requiredTest-first proof
The RED contract proves the standard Intel repository target was absent; the narrow production fix adds only
Path::new("/usr/local/Homebrew/bin/brew"). Existingsymlink_metadata, executable-bit admission, symlink rejection, opened-file device/inode binding,/dev/fd/3execution, fixed arguments, plan fingerprinting, dry-run, model judgment, exact approval, and audit publication remain unchanged.Stack / ownership
Dependency order is #264 release artifact contract → #187 durable audit authority → this Intel compatibility slice → #206 content-bound executable bytes. The branch was refreshed with ordinary two-parent history, preserving every valid predecessor commit and the canonical owner delta.
Required before merge
Keep Draft until parent dependencies are integrated or deliberately preserved; every applicable exact-head native and central workflow passes; every valid current-head finding is addressed; repository-wide exact 100% owned-production coverage is satisfied without weakening; package/SBOM/provenance/release requirements are complete where applicable; and fresh stack/base ancestry remains current. Pending, queued, absent-required, skipped-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, or author-only evidence is non-passing.