Repository navigation
fix(review): gate capability proxy before provider send - #1240
Draft
seonghobae wants to merge 2 commits into
Draft
seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Issue #1106 follow-up stacked on Draft #1235. An admitted free chat and rerank candidate could be reached through
proxy_capabilitywith an explicit model even while the review allocation contract was unavailable. The shared capability entry now checks that contract before candidate selection/provider send. The HTTP capability handler preserves the typed upstream error instead of converting it tocapability_unavailable.Evidence
119367eausing synthetic rerank input./v1/rerankregressions assert explicit model → nonretryable 400review_model_not_allowed,orchestrator/free→ nonretryable 503allocation_evidence_unavailable, with zero provider sends.python -m pytest -q tests/test_review_gateway_admission_contract_1106.py tests/test_multimodal_model_group_http.py tests/test_provider_error_taxonomy.py: 87 passed (local; one pre-existing pytest config warning).docs/doctoring/review_gateway_supported_path_receipt.mdrecords the separate supported runner path and why hosted before/after capacity numbers are unavailable. The earlier same-host synthetic receipt is boundary evidence only.Draft/HOLD: no merge or deployment. Required checks, independent review, exact hosted build and comparable live request-path evidence remain open.