Skip to content

fix(review): gate direct embedding batch submission - #1241

Draft
seonghobae wants to merge 1 commit into
fix-review-capability-admissionfrom
fix-review-embedding-admission
Draft

seonghobae wants to merge 1 commit into
fix-review-capability-admissionfrom
fix-review-embedding-admission

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Scope

Issue #1106 follow-up stacked on Draft #1240. A synthetic free chat+embedding model admitted to the review pool could be submitted through the public CostRoutingCoordinator.submit_embeddings_batch API with an explicit member model. This direct path bypassed the HTTP embedding preflight and reached the batch backend before review allocation evidence was available.

The coordinator now applies the existing review allocation guard before backend refresh, route selection, reservation, or submission. The default non-review coordinator behavior is unchanged.

RED and GREEN

  • RED at parent fix(review): gate capability proxy before provider send #1240 10908004: direct submit_embeddings_batch(["synthetic"], model="router-review") reached a synthetic backend submission and failed the no-send assertion.
  • GREEN at c2c72b6d: explicit member model returns nonretryable 400 review_model_not_allowed; orchestrator/free returns nonretryable 503 allocation_evidence_unavailable; both make zero backend submissions.
  • Local bounded suites: 52 pass (review admission, batch embeddings, embedding HTTP honesty); 96 pass (cost router and batch endpoint regressions).
  • Expanded test_provider_embedding_batch_backend.py could not collect because that existing test imports _DEFAULT_EMBEDDING_CLAIM_LEASE_SECONDS, while the source declares _DEFAULT_PROVIDER_EMBEDDING_CLAIM_LEASE_SECONDS. This mismatch is outside this focused change; no claim of full-suite success.

Draft/HOLD. No company content, secrets, provider egress, merge, or deployment. Parent PRs, released allocation evidence, required hosted checks, and independent review remain pending.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant