Repository navigation
fix(review): gate direct embedding batch submission - #1241
Draft
seonghobae wants to merge 1 commit into
Draft
seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Issue #1106 follow-up stacked on Draft #1240. A synthetic free chat+embedding model admitted to the review pool could be submitted through the public
CostRoutingCoordinator.submit_embeddings_batchAPI with an explicit member model. This direct path bypassed the HTTP embedding preflight and reached the batch backend before review allocation evidence was available.The coordinator now applies the existing review allocation guard before backend refresh, route selection, reservation, or submission. The default non-review coordinator behavior is unchanged.
RED and GREEN
10908004: directsubmit_embeddings_batch(["synthetic"], model="router-review")reached a synthetic backend submission and failed the no-send assertion.c2c72b6d: explicit member model returns nonretryable 400review_model_not_allowed;orchestrator/freereturns nonretryable 503allocation_evidence_unavailable; both make zero backend submissions.test_provider_embedding_batch_backend.pycould not collect because that existing test imports_DEFAULT_EMBEDDING_CLAIM_LEASE_SECONDS, while the source declares_DEFAULT_PROVIDER_EMBEDDING_CLAIM_LEASE_SECONDS. This mismatch is outside this focused change; no claim of full-suite success.Draft/HOLD. No company content, secrets, provider egress, merge, or deployment. Parent PRs, released allocation evidence, required hosted checks, and independent review remain pending.