fix(nim): preserve current hosted-access evidence on trusted branch - #1068
seonghobae wants to merge 5 commits into
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…' into codex/nim-evidence-successor
Preserve the complete NIM evidence successor delta while incorporating the current stacked-security successor without force-push or destructive rebase. Signed-off-by: Seongho Bae <me@seonghobae.me>
Resolve the NVIDIA hosted-access evidence conflict by combining both sides: this branch's cited source and main's validity date. main's #1073 refreshed only the dates (2026-08-05 -> 2026-09-05, valid_until 2026-09-04 -> 2026-10-05) and never touched the source document, so switching the citation to "Run NIM Anywhere" is this branch's own delta -- taking main's side would leave the PR a no-op. The dates go the other way: the established convention is reviewed_at + 30 days (base: 08-05 -> 09-04), which main's 2026-10-05 follows and this branch's 2026-10-04 misses by one. Two things the conflict markers did not show: - nim_benchmark.py:2538 validates source_url against a hard-coded literal and auto-merged cleanly to this branch's "run-anywhere" while line 116 was still conflicted. Picking main's "/product" there would have left the module rejecting its own default evidence. - CHANGELOG.md still read 2026-10-04 after the resolution; it auto-merged without conflict because only this branch had touched it. The conflicting test mutation is the same test on both sides, each adjusted to its own dates. Under valid_until=2026-10-05 only main's mutation still triggers "validity precedes", so it is the one kept. Verified: 3396 passed, 1 skipped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
이 PR은 #1073으로 대체되지 않았습니다 — 충돌 해소 완료다른 세션의 레인 조정에서 이 PR이 "NIM 비용 근거 갱신 PR의 여섯 번째 중복이며 #1073( main이 실제로 갖고 있는 것#1073이 실제로 바꾼 것 — 날짜 두 줄뿐출처 문서는 건드리지 않았습니다. 이 PR의 고유 delta이 브랜치는 인용 출처 자체를 교체합니다 — 세 번째 축도 있습니다:
충돌 해소 (
|
|
Adjudication evidence (host 1 session, 2026-09-06 KST; full report with commands in #1080). Nothing here closes, flips, or retargets anything — the decision is the opener's. Only member of the #1063/#1069/#1068 trio that is clean on current main ( Stale: the gap-baseline citation of #1063's |
_record_success (orchestrator.py:8073-8077 at pin 414f229) pops the agent's circuit state rather than decrementing it, so with a threshold of 3 any single success zeroes the accumulated failure count. A route that alternates failure and success -- what an overloaded provider does -- never reaches the threshold and is never excluded, however long each failure runs. Recorded as a property rather than one log's reading: the same sequence appeared on three separate pull requests on 2026-09-06, each on the single ready route the post-.github#1957 preflight had found. Also corrects how far #911 is from landing. It is not merely unmerged: its base is codex/nim-evidence-successor, which is #1068 (open), itself based on codex/stacked-security-successor. "Once #911 lands" requires that whole stack. The conclusion is unchanged -- a fixed wall-clock deadline on the candidate/retry loop is still barred by product-goal-directive section 8. The count of missing pieces in the not-yet-built exclusion mechanism goes from two to three. Gate: 3392 passed, 3 failed, 2 skipped. All three failures are pre-existing and reproduce identically on origin/main (missing fast_mlsirm, missing OTLP HTTP exporter, and test_spend_analytics asserting mixed vs tokenizer); this change is documentation only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
Outcome
Carries the complete effective delta from fork PR #1063 onto a trusted base-repository branch. A fresh exact-head failure in prerequisite #1066 has now exposed that the NIM evidence refresh must be integrated before the security-workflow stack rather than only as its child.
Current lineage
efd8032a6902c2a7499be9ff921628fab491daeb0cdc0307f0fd9f368f89eba3036c5538edbefb7251c8824e219c887425d2e7147e87f088d5f1a77d2e414d15ba58f28597751b625a8a2f00fc9fadcfb0bd71dfa5d6ca065052bc951ad9c9209b88413b, direct child of protected main#1068 remains a valid trusted copy of the six NIM evidence blobs, but its stack position is no longer sufficient. #1066's repository
Security and Qualityrun33923471573, job101186730296, executed on a real GitHub-hosted runner and failed5 failed, 3390 passed, 2 skippedbecause protected main's evidence expired after 2026-09-04. That failure occurs before this child branch can contribute its refreshed evidence.Fresh official NVIDIA
Run NIM Anywheredocumentation was re-reviewed on 2026-09-05 and still states free hosted NIM API endpoint access for NVIDIA Developer Program prototyping while distinguishing production NVIDIA AI Enterprise licensing. #1069 therefore carries the same six reviewed evidence/test/doc blobs from this branch onto a clean main child without #1066's security-workflow ancestry.Repair order
Evidence boundary
The six NIM files here are unchanged from the reviewed refresh:
CHANGELOG.md,contextual_orchestrator/nim_benchmark.py, two NIM evidence docs,docs/product-technical-gap-baseline.md, andtests/test_nim_benchmark_release_acceptance.py. They preserve only time-bounded prototype-access evidence through 2026-10-04; no production price, licensing, support, or deployed-capacity claim is inferred.Keep Draft. Historical checks do not transfer across the reordered stack, and no force push, destructive rebase, self-approval, no-op retrigger, admin bypass, or gate weakening is valid acceptance evidence.