Skip to content

feat(workspace): name tonight's first simpler take on the map - #990

Open
seonghobae wants to merge 8 commits into
developfrom
feat/workspace-first-simplification
Open

feat(workspace): name tonight's first simpler take on the map#990
seonghobae wants to merge 8 commits into
developfrom
feat/workspace-first-simplification

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Product outcome

Name tonight's first simpler take so the room can get through the section together. The mounted workspace copy names the owning part, the labeled section, and the time. Open moves to the matching rendered map section. The owned simplification hint is shown as a separate line so the next action is obvious.

Protected target: develop@749511c3ad4000090048718f685c6bee6b3d2c25 (#783 npm/PDF.js/Nanoid/Undici baseline and #957 first playable range).
Exact current head: b65160084583f09423a6d1bd0ccc3ffafb20bc4a.

This branch was rebased onto current develop. The shipped first-range callout stays. Predecessor 3736a1647ec06251214005b82552717fd8dd8b69 and its checks are historical only.

Current exact scope

  • Resolve the earliest section whose unique active ranked role owns a non-empty simplification string.
  • Prefer the highest rehearsal priority, then a locale-independent role id.
  • Do not invent an easier pass from setupNote, cue text, overlap warnings, whitespace, inherited fields, or accessor metadata.
  • Bound the hint to 180 Unicode code points and render it as a text node; never rescan it as template syntax.
  • Open scrolls the renderer-owned song-structure-grid child (data-section-index). Analysis section.id is never DOM-ID authority. Reduced-motion uses behavior: "auto" against that same renderer child, not accessible copy.
  • Keep the unavailable state guidance-only: stay on tonight's map until a part names an easier pass.
  • Korean copy keeps dynamic role names particle-safe (파트가 / 파트와).
  • Distinct from first-range, first-setup, first-lyric, first-priority, first-tag, and first-form-label work.

Merge gate

Queued, pending, skipped-required, failed, predecessor-head, protected-base, self/author, model-only, or administrative-bypass evidence is non-passing.

Security Notes

  • Untrusted input: song, section, time-range, role, part-graph, and simplification strings.
  • Trust boundary: owned data properties only; renderer-owned song-structure children are the only navigation targets.
  • Safe failure: inherited/accessor/array metadata, empty hints, setup notes, cues, and overlap warnings cannot establish a simpler take.
  • Privacy: no filesystem, URL, or payload contents are rendered in the callout.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 36 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d162342-e9e2-4d99-9f6e-64ddb73136be

📥 Commits

Reviewing files that changed from the base of the PR and between 749511c and b651600.

📒 Files selected for processing (20)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE.md
  • apps/desktop/src/features/workspace/FirstSimplificationCallout.particle.test.tsx
  • apps/desktop/src/features/workspace/FirstSimplificationCallout.reduced-motion.test.tsx
  • apps/desktop/src/features/workspace/FirstSimplificationCallout.test.tsx
  • apps/desktop/src/features/workspace/FirstSimplificationCallout.tsx
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/features/workspace/Workspace.tsx
  • apps/desktop/src/features/workspace/firstSimplification.inherited-metadata.test.ts
  • apps/desktop/src/features/workspace/firstSimplification.test.ts
  • apps/desktop/src/features/workspace/firstSimplification.ts
  • apps/desktop/src/i18n/index.test.ts
  • apps/desktop/src/i18n/index.ts
  • apps/desktop/src/locales/en/common.json
  • apps/desktop/src/locales/ko/common.json
  • apps/desktop/vite.config.ts
  • docs/design-system/component-contract.md
  • docs/doctoring/reduced-motion-first-simplification-navigation.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae
seonghobae marked this pull request as draft August 23, 2026 11:20
devin-ai-integration[bot]

This comment was marked as resolved.

Name the owning part, labeled section, and time for the first owned
simplification hint so the room can take the easier pass together.
Open scrolls the renderer-owned song-structure section. Setup notes,
cues, and overlap warnings cannot invent a simpler take.
…ion scroll

The Open action already looks up data-testid=song-structure-grid, not
accessible copy. Point the reduced-motion fixture at that same renderer
child so the immediate-scroll contract stays executable after the
navigation decoupling.
@seonghobae
seonghobae force-pushed the feat/workspace-first-simplification branch from 3736a16 to b651600 Compare August 31, 2026 09:34
@seonghobae
seonghobae marked this pull request as ready for review August 31, 2026 09:34
@seonghobae seonghobae added enhancement New feature or request type: feature New or expanded product capability priority: medium Normal-priority or P2 work labels Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant