feat(workspace): name the selected part's first-pass take - #1151
feat(workspace): name the selected part's first-pass take#1151seonghobae wants to merge 1 commit into
Conversation
After a named part is selected, the ready rehearsal map names that part's first trusted simplification and tells the player to play that simpler take before adding the rest. Untrusted or missing takes still name the next action instead of hiding it.
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const selectedFirstPass = useMemo( | ||
| () => (activeRole ? firstPassSimplification(song, activeRole) : null), | ||
| [activeRole, song] | ||
| ); |
There was a problem hiding this comment.
🟡 Loaded projects inherit stale part selection
Loading another project preserves activeRole from the previous song. firstPassSimplification then displays guidance for an unselected part or a nonexistent one.
Prompt for agents
Reset or reconcile Workspace's activeRole whenever the song identity changes. App.handleLoadProject replaces jobResult while rendering the same Workspace component, so local state survives across projects. Preserve activeRole for ordinary immutable updates to the same song, but clear it when song.id changes or when the selected role no longer exists in roleMap. Add a regression test that selects a role, rerenders Workspace with a different song, and verifies the first-pass callout stays hidden until a role in the new song is selected.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Superseded by the canonical selected-part guidance vertical #1150
This PR is closed unmerged only after its complete valid product/test/evidence delta was reconstructed on the canonical #1150 branch. The closure is queue convergence, not a merge-readiness claim, and no predecessor check/review/approval/status transfers.
Exact succession identity
4471a4bee81e505f9343e9fbb24e9f77b40280cddevelop@749511c3ad4000090048718f685c6bee6b3d2c258821ae1bda6c4111a0f531865fca3e726628848e#1150 advanced from its original entrance-cue head by ordinary forward commits that explicitly reconstruct the selected-part first-pass domain, mounted Workspace behavior, regressions, doctoring evidence, EN/KO copy, and then the confirmed-chord sibling behavior on the same vertical. No force update or destructive rebase was used.
Verified transfer
The predecessor and successor carry identical Git blobs for the unique first-pass artifacts:
apps/desktop/src/features/workspace/firstPassSimplification.ts—c8937c591d4732a512b33c58f299303d5871a687apps/desktop/src/features/workspace/firstPassSimplification.test.ts—909cd2fabb81131929bc491c59fc44742ab9d24eapps/desktop/src/features/workspace/Workspace.first-pass.test.tsx—8dee9a185edb86b8a140724a92295ab42a102209docs/doctoring/selected-part-first-pass.md—8fa5f90c1dcb6c605b36f5102dc13c6ab5114838The shared
Workspace.tsx, EN/KO locale resources, AGENTS/ARCHITECTURE/CHANGELOG/CLAUDE, and component contract are intentionally a union on #1150: entrance cue + first-pass take + confirmed chord coexist under one selected-part guidance owner. #1150 also corrected the selected-part design contract to mark Figma nodes pending live verification rather than reuse an unverified node id.Evidence boundary
#1150 must earn fresh checks, reviews, thread resolution, UI evidence, and a qualifying independent non-author last-push approval on its own unchanged exact head. Nothing from #1151 is treated as passing evidence for #1150.
Relates to #966.