Skip to content

fix(a11y): preserve decorative icon accessibility repair - #740

Draft
seonghobae wants to merge 3 commits into
developmentalfrom
fix/a11y-decorative-icons-successor-20261002
Draft

seonghobae wants to merge 3 commits into
developmentalfrom
fix/a11y-decorative-icons-successor-20261002

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 1, 2026 •

Copy link
Copy Markdown

2026-10-02 post-successor drift

Predecessor #739 advanced after successor creation to 865abe4dba7b5d694034033cb051b0ffa989a8a6. Exact comparison from this successor head 6ec05980845555c6f1a9fce92906be5c840de576 reports zero changed files; therefore this stable branch still carries every effective delta. No predecessor retirement is authorized yet.

Verified successor scope

This Draft successor isolates the complete valid accessibility delta from predecessor #739 after its generator-owned branch advanced twice with empty duplicate commits while exact-head review was in progress.

  • protected base: developmental@2fa92012bcf80acc1f921a4bafea76b3b1424b46;
  • predecessor head captured without force: 6ec05980845555c6f1a9fce92906be5c840de576;
  • successor starts at the exact same commit/tree and preserves all predecessor ancestry;
  • comparison b779f1e… → fdf876e… → 6ec0598… is two commits ahead with zero file changes;
  • effective diff remains six report components adding aria-hidden="true" only to decorative icons whose adjacent text or enclosing control supplies the accessible name.

Lifecycle and blockers

Status: Draft / stable successor.

Predecessor #739 remains open as provenance; do not close it until this successor is independently verified and integrated.

The predecessor's exact-tree CI and Semgrep were GREEN, but those results do not transfer. The protected base still exposes seven dependency findings owned by #615, and CodeQL materialization is blocked by the central owner gap tracked in ContextualWisdomLab/.github#2548. Require this successor's own terminal CI, Security, Semgrep, CodeQL, zero unresolved review findings, and qualifying independent approval before ordinary merge. No auto-merge is enabled.

리포트 대시보드 컴포넌트들(`delegation-insight`, `learn-from-group`, `usage-scale-group`, `skill-assets-insight`, `context-section`, `week-navigator`) 내부에서 사용되는 순수 장식용 아이콘들(lucide-react)에 `aria-hidden="true"` 속성을 추가하여 스크린 리더가 불필요하게 아이콘을 읽지 않도록 접근성을 개선했습니다.
리포트 대시보드 컴포넌트들(`delegation-insight`, `learn-from-group`, `usage-scale-group`, `skill-assets-insight`, `context-section`, `week-navigator`) 내부에서 사용되는 순수 장식용 아이콘들(lucide-react)에 `aria-hidden="true"` 속성을 추가하여 스크린 리더가 불필요하게 아이콘을 읽지 않도록 접근성을 개선했습니다.
리포트 대시보드 컴포넌트들(`delegation-insight`, `learn-from-group`, `usage-scale-group`, `skill-assets-insight`, `context-section`, `week-navigator`) 내부에서 사용되는 순수 장식용 아이콘들(lucide-react)에 `aria-hidden="true"` 속성을 추가하여 스크린 리더가 불필요하게 아이콘을 읽지 않도록 접근성을 개선했습니다.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae added status: draft Draft pull request type: bug Defect or incorrect behavior priority: medium Normal-priority or P2 work area: ui-ux Frontend, interaction, design, or user experience labels Oct 1, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui-ux Frontend, interaction, design, or user experience priority: medium Normal-priority or P2 work status: draft Draft pull request type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant