fix(a11y): preserve decorative icon accessibility repair - #740
Draft
seonghobae wants to merge 3 commits into
Draft
seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
리포트 대시보드 컴포넌트들(`delegation-insight`, `learn-from-group`, `usage-scale-group`, `skill-assets-insight`, `context-section`, `week-navigator`) 내부에서 사용되는 순수 장식용 아이콘들(lucide-react)에 `aria-hidden="true"` 속성을 추가하여 스크린 리더가 불필요하게 아이콘을 읽지 않도록 접근성을 개선했습니다.
리포트 대시보드 컴포넌트들(`delegation-insight`, `learn-from-group`, `usage-scale-group`, `skill-assets-insight`, `context-section`, `week-navigator`) 내부에서 사용되는 순수 장식용 아이콘들(lucide-react)에 `aria-hidden="true"` 속성을 추가하여 스크린 리더가 불필요하게 아이콘을 읽지 않도록 접근성을 개선했습니다.
리포트 대시보드 컴포넌트들(`delegation-insight`, `learn-from-group`, `usage-scale-group`, `skill-assets-insight`, `context-section`, `week-navigator`) 내부에서 사용되는 순수 장식용 아이콘들(lucide-react)에 `aria-hidden="true"` 속성을 추가하여 스크린 리더가 불필요하게 아이콘을 읽지 않도록 접근성을 개선했습니다.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-10-02 post-successor drift
Predecessor #739 advanced after successor creation to
865abe4dba7b5d694034033cb051b0ffa989a8a6. Exact comparison from this successor head6ec05980845555c6f1a9fce92906be5c840de576reports zero changed files; therefore this stable branch still carries every effective delta. No predecessor retirement is authorized yet.Verified successor scope
This Draft successor isolates the complete valid accessibility delta from predecessor #739 after its generator-owned branch advanced twice with empty duplicate commits while exact-head review was in progress.
developmental@2fa92012bcf80acc1f921a4bafea76b3b1424b46;6ec05980845555c6f1a9fce92906be5c840de576;b779f1e… → fdf876e… → 6ec0598…is two commits ahead with zero file changes;aria-hidden="true"only to decorative icons whose adjacent text or enclosing control supplies the accessible name.Lifecycle and blockers
Status: Draft / stable successor.
Predecessor #739 remains open as provenance; do not close it until this successor is independently verified and integrated.
The predecessor's exact-tree CI and Semgrep were GREEN, but those results do not transfer. The protected base still exposes seven dependency findings owned by #615, and CodeQL materialization is blocked by the central owner gap tracked in ContextualWisdomLab/.github#2548. Require this successor's own terminal CI, Security, Semgrep, CodeQL, zero unresolved review findings, and qualifying independent approval before ordinary merge. No auto-merge is enabled.