Repository navigation
fix(a11y): hide redundant navigation and tooltip icons - #746
seonghobae wants to merge 2 commits into
Conversation
…ements Adds `aria-hidden="true"` to lucide-react icons in `pagination.tsx`, `week-navigator.tsx`, and `info-tooltip.tsx` where the parent interactive element already provides a descriptive `aria-label`. This prevents redundant screen reader announcements and improves accessibility.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…ements Adds `aria-hidden="true"` to lucide-react icons in `pagination.tsx`, `week-navigator.tsx`, and `info-tooltip.tsx` where the parent interactive element already provides a descriptive `aria-label`. This prevents redundant screen reader announcements and improves accessibility.
seonghobae
changed the title
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Current lifecycle
a4ffab21559c8b85728a6107ac165a59059b2d51developmental@2fa92012bcf80acc1f921a4bafea76b3b1424b46BlobNotFoundThe two
week-navigator.tsxchanges overlap with stable accessibility successor #740 at6ec05980845555c6f1a9fce92906be5c840de576. Thepagination.tsxandinfo-tooltip.tsxchanges are additional valid deltas not present in #740, so this PR is not a complete duplicate and must not be closed or retired.The patch is mechanically narrow and every affected control already supplies an accessible name, but no committed accessibility-tree, keyboard/interaction, component, Storybook, or E2E regression binds the new behavior. A zero-step infrastructure failure is neither product RED nor GREEN. Keep Draft until an unchanged exact head has executable evidence, required Checks, and qualifying independent approval.
Original generated proposal (preserved for provenance)
💡 What
접근성 향상을 위해 UI 컴포넌트 내의 장식용 아이콘들에
aria-hidden="true"속성을 추가했습니다.🎯 Why
스크린 리더를 사용하는 사용자들이 화면을 탐색할 때, 이미
aria-label이 지정된 버튼이나 링크 내부에 있는 아이콘의 기본 이름까지 중복해서 읽히는 문제를 해결하여 보다 깔끔하고 명확한 청각적 경험을 제공하기 위함입니다. (예:ChevronLeft아이콘 등)📸 Before/After
시각적인 변화는 없습니다. (스크린 리더 동작 최적화)
♿ Accessibility
packages/web/src/components/ui/pagination.tsx: 페이지네이션 버튼 내부의ChevronLeftIcon,ChevronRightIcon중복 읽기 방지packages/web/src/components/dashboard/reports/week-navigator.tsx: 주간 네비게이터 링크 내부의ChevronLeft,ChevronRight중복 읽기 방지packages/web/src/components/ui/info-tooltip.tsx: 툴팁 트리거 내부의Info아이콘 중복 읽기 방지PR created automatically by Jules for task 13060252348292348486 started by @seonghobae