Skip to content

๐Ÿ›ก๏ธ Sentinel: [HIGH] Fix DOM XSS via type coercion and escaping - #1418

Closed
seonghobae wants to merge 1 commit into
developfrom
fix-dom-xss-console-3045702934668945300
Closed

seonghobae wants to merge 1 commit into
developfrom
fix-dom-xss-console-3045702934668945300

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿšจ Severity: HIGH

๐Ÿ’ก Vulnerability: untrusted numerical data ๋ฐ severity ๋ฌธ์ž์—ด ๋“ฑ์ด scanner/dashboard/console.html์—์„œ escaping ๋˜๋Š” ํƒ€์ž… ๊ฐ•์ œ ๋ณ€ํ™˜ ์—†์ด innerHTML์— ์‚ฝ์ž…๋˜์–ด DOM XSS ์ทจ์•ฝ์ ์ด ์กด์žฌํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Impact: ๊ณต๊ฒฉ์ž๊ฐ€ ์•…์˜์ ์ธ ํŽ˜์ด๋กœ๋“œ๊ฐ€ ํฌํ•จ๋œ ์Šค์บ” ๊ฒฐ๊ณผ๋ฅผ ์ฃผ์ž…ํ•˜๋ฉด, ์ฝ˜์†” ๋ทฐ์–ด๋ฅผ ๋ณด๋Š” ๊ด€๋ฆฌ์ž์˜ ๋ธŒ๋ผ์šฐ์ €์—์„œ ์Šคํฌ๋ฆฝํŠธ๊ฐ€ ์‹คํ–‰๋˜์–ด ์„ธ์…˜ ํƒˆ์ทจ ๋“ฑ์˜ ๊ณต๊ฒฉ์ด ๊ฐ€๋Šฅํ•ด์ง‘๋‹ˆ๋‹ค.

๐Ÿ”ง Fix:

  • ์ˆ˜์น˜ํ˜• ๋ฐ์ดํ„ฐ์— ๋Œ€ํ•ด Number() ๋ž˜ํผ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ๋™์  DOM ์ƒ์„ฑ ์‹œ ํƒ€์ž…์„ ์—„๊ฒฉํžˆ ์ œ์–ดํ–ˆ์Šต๋‹ˆ๋‹ค.
  • String(f.severity).toUpperCase()๋กœ ์ •๊ทœํ™”ํ•˜์—ฌ ๋”•์…”๋„ˆ๋ฆฌ ๋งคํ•‘ ์ทจ์•ฝ์ ์„ ๋ฐฉ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • esc() ๋ž˜ํผ๋ฅผ ์‚ฌ์šฉํ•ด untrusted ๊ฐ’์„ ํ™•์‹คํ•˜๊ฒŒ escaping ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

โœ… Verification: Playwright๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ DOM์„ ๋ Œ๋”๋งํ•˜๊ณ  ์•…์˜์  ์ž…๋ ฅ๊ฐ’์ด ์ฃผ์ž…๋œ ๊ฐ€์ƒ์˜ ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ๋ฅผ ๋ถˆ๋Ÿฌ์™”์„ ๋•Œ ์ •์ƒ์ ์œผ๋กœ ํ…์ŠคํŠธ๋กœ ์ฒ˜๋ฆฌ๋˜๊ณ  ์Šคํฌ๋ฆฝํŠธ๊ฐ€ ์‹คํ–‰๋˜์ง€ ์•Š์Œ์„ ์Šคํฌ๋ฆฐ์ƒท์œผ๋กœ ํ™•์ธํ•˜์˜€๊ณ , Python ๋‹จ์œ„ ํ…Œ์ŠคํŠธ( test_console_dashboard_security.py)๊ฐ€ ํ†ต๊ณผํ•จ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 3045702934668945300 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: Youโ€™ve used the included review currently available.

Learn how review limits work.

Review configuration:

โš™๏ธ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eac8f036-751f-4a8d-bd4a-69229a8eac8a
๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 2949d30 and 7ca5acd.

๐Ÿ“’ Files selected for processing (2)
  • .jules/sentinel.md
  • scanner/dashboard/console.html
  • Autopilot ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Verified complete successor carryover before retirement

Exact source head: 7ca5acd0f31b6f22e566f91629ad3e183dcd6588.

Every valid delta is preserved more strongly by the canonical stack:

#1418's Number(...) || 0 admits negative, fractional and infinite values and has no committed executable regression; it is therefore weaker than #1314. Its DOM-XSS claim is not independently reproduced beyond the scalar/attribute boundary already carried.

This PR is being retired unmerged only after verified complete carryover. No branch deletion, force push, gate bypass, approval transfer, or release claim is made.

@seonghobae seonghobae closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant