Skip to content

chore(a11y): duplicate carried by #1344 - #1383

Closed
seonghobae wants to merge 2 commits into
developfrom
palette/keyboard-shortcut-a11y-224454939057473698
Closed

seonghobae wants to merge 2 commits into
developfrom
palette/keyboard-shortcut-a11y-224454939057473698

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Retired after verified complete successor carryover

#1344 preserves the same user-visible Escape hint and programmatic aria-keyshortcuts="Escape" behavior for both console render paths and the index dialog, and adds executable regressions. Fresh exact-head validation is focused 21/21, full 1,091/1,091, diff-whitespace clean, with nine terminal-success hosted workflows. It remains Draft/open with no qualifying approval; this retirement transfers neither approval nor merge readiness.

The alternate Close details (Esc) wording and generated .jules lesson are not independent functionality or security evidence. No force push, destructive rebase, gate weakening, or valid-delta loss occurred.

아이콘만 있는 닫기 버튼에 단축키(`Esc`)를 시각적 툴팁(`title="Close details (Esc)"`) 및 프로그래매틱 속성(`aria-keyshortcuts="Escape"`)으로 추가했습니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

중복 writer 정리 전 완전 승계 검증

  • 이 PR 원본 exact head: 2b380b9e8ffa7d8b9df5526939856510cbbcba9e
  • canonical successor: #1344 exact 707ab2e02cdab1f4187b78302abe154afdcf9fed
  • 동일 동작: console 성공/오류 닫기 버튼의 시각적 Escape 힌트와 aria-keyshortcuts="Escape", index dialog의 aria-keyshortcuts="Escape"
  • #1344의 추가 보호: tests/test_console_dashboard_security.py, tests/test_dashboard_core.py 실행 회귀
  • fresh local exact-head 검증: focused 21/21, full 1,091/1,091, git diff --check 통과
  • hosted exact-head: Tests, Security Scan, SAST, Scan path, Pinned HTTPS, OpenSSF, Security Process, Retention, CodeQL PR의 9개 workflow 모두 terminal SUCCESS
  • review boundary: unresolved thread 0, qualifying approval 0; #1344는 보호 통합 전 Draft/Proposed 유지

#1383의 Close details (Esc)와 #1344의 Close (Esc) 차이는 별도 기능·보안·접근성 계약이 아니라 같은 Escape 발견성 문구의 표현 차이입니다. #1344가 사용자 가시 동작과 프로그래매틱 ARIA 계약을 모두 보존하며 더 강한 실행 회귀를 제공합니다. 따라서 원본 ancestry를 보존하고 protected tree와 동일한 ordinary two-parent child로 만든 뒤에만 complete-successor-carryover 예외로 종료합니다.

@seonghobae
seonghobae marked this pull request as draft October 3, 2026 15:12
Preserve the original #1383 ancestry and current protected develop while restoring the protected tree. #1344 exact 707ab2e carries the same Escape tooltip/ARIA behavior plus executable regressions and terminal exact-head checks.
@seonghobae seonghobae changed the title 🎨 Palette: 키보드 단축키 접근성 향상 chore(a11y): duplicate carried by #1344 Oct 3, 2026
@seonghobae seonghobae closed this Oct 3, 2026
@google-labs-jules

Copy link
Copy Markdown

중복 writer 정리 전 완전 승계 검증

  • 이 PR 원본 exact head: 2b380b9e8ffa7d8b9df5526939856510cbbcba9e
  • canonical successor: #1344 exact 707ab2e02cdab1f4187b78302abe154afdcf9fed
  • 동일 동작: console 성공/오류 닫기 버튼의 시각적 Escape 힌트와 aria-keyshortcuts="Escape", index dialog의 aria-keyshortcuts="Escape"
  • #1344의 추가 보호: tests/test_console_dashboard_security.py, tests/test_dashboard_core.py 실행 회귀
  • fresh local exact-head 검증: focused 21/21, full 1,091/1,091, git diff --check 통과
  • hosted exact-head: Tests, Security Scan, SAST, Scan path, Pinned HTTPS, OpenSSF, Security Process, Retention, CodeQL PR의 9개 workflow 모두 terminal SUCCESS
  • review boundary: unresolved thread 0, qualifying approval 0; #1344는 보호 통합 전 Draft/Proposed 유지

#1383의 Close details (Esc)와 #1344의 Close (Esc) 차이는 별도 기능·보안·접근성 계약이 아니라 같은 Escape 발견성 문구의 표현 차이입니다. #1344가 사용자 가시 동작과 프로그래매틱 ARIA 계약을 모두 보존하며 더 강한 실행 회귀를 제공합니다. 따라서 원본 ancestry를 보존하고 protected tree와 동일한 ordinary two-parent child로 만든 뒤에만 complete-successor-carryover 예외로 종료합니다.

외부 인프라 문제(GitHub Actions 계정 잠금 - 결제 이슈)로 인해 CI가 실패하고 있습니다. 이 문제는 코드베이스 수정으로 해결할 수 없습니다. 계정 결제 문제를 해결한 후 CI를 다시 실행해 주시기 바랍니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant